Skip to content

chore(ci): evaluate line-by-line Code Style specialist for Gemini review council (tracking, NOT a one-shot) #633

Description

@rafeekpro

Summary — tracking issue, NOT a one-shot fix

This is a tracking issue for evaluating whether (and how) to add a line-by-line code-style review specialist to rafeekpro/dap's AI review gate. It cannot be shipped via DAP as a one-shot the way the speacher / news-sentiment / cortex-project / cfd fan-out can, because dap's review architecture is fundamentally different.

Why dap is different from the other 4 repos

The other 4 repos use .github/workflows/copilot-review-required.yml — a single workflow file with a const AGENTS = [...] JavaScript array embedded in a gh script step. Adding a new specialist there is a small YAML/JS edit.

dap uses .github/workflows/gemini-review.yml — a different workflow that:

  • Installs packages/code-review-council (an in-tree Python package — pip install -e ./packages/code-review-council)
  • Invokes the council via that package's CLI
  • The specialist roster lives inside the Python package, not inline in YAML

So fanning out the Code Style specialist to dap means:

  1. Modify packages/code-review-council/ to add a Code Style specialist class/config
  2. Possibly update the package's prompt assembly, schema, output parsers
  3. Bump the package version
  4. Re-test with Gemini (different model — line-by-line citation behavior may differ from claude/codex)

That's an architectural change to the in-tree code-review-council package, not a YAML diff. It's also subject to the DAP rule about not running DAP autonomously against rafeekpro/dap (DB-wipe risk per memory dap-self-fix-known-dangerous).

Path forward — investigate, do not auto-execute

Recommended steps (manual, NOT via DAP autonomous run):

  1. Read the in-tree package at packages/code-review-council/. Identify where specialists are registered.
  2. Determine if Gemini's review output format supports the same file:line citation contract the claude/codex council uses. If yes, the fan-out is mechanically possible. If no, this becomes "design a Gemini-specific line-by-line specialist."
  3. Author a Code Style specialist module in the package, modeled on the existing 6 specialists.
  4. Test on a no-op PR to dap before promoting.
  5. Ship via a normal PR authored manually (NOT autonomously by DAP).

Acceptance criteria (when work eventually happens)

  • packages/code-review-council/ has +1 specialist module for Code Style
  • The package's CLI invokes it as part of the council
  • Test PR on dap exercises it and produces file:line citations in the review output
  • Existing 6 specialists' output unchanged

Out of scope

  • Auto-shipping via DAP (rafeekpro/dap is on the DO-NOT-AUTO list)
  • Changing the Gemini API key handling
  • Migrating dap to claude-bridge or codex-bridge

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ci.github/workflows, runners, CI containersenhancementNew feature or requestsize:L1-3 days, may touch multiple modulestech-debtKnown-bad we want to clean up

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions