Summary — tracking issue, NOT a one-shot fix
This is a tracking issue for evaluating whether (and how) to add a line-by-line code-style review specialist to rafeekpro/dap's AI review gate. It cannot be shipped via DAP as a one-shot the way the speacher / news-sentiment / cortex-project / cfd fan-out can, because dap's review architecture is fundamentally different.
Why dap is different from the other 4 repos
The other 4 repos use .github/workflows/copilot-review-required.yml — a single workflow file with a const AGENTS = [...] JavaScript array embedded in a gh script step. Adding a new specialist there is a small YAML/JS edit.
dap uses .github/workflows/gemini-review.yml — a different workflow that:
- Installs
packages/code-review-council (an in-tree Python package — pip install -e ./packages/code-review-council)
- Invokes the council via that package's CLI
- The specialist roster lives inside the Python package, not inline in YAML
So fanning out the Code Style specialist to dap means:
- Modify
packages/code-review-council/ to add a Code Style specialist class/config
- Possibly update the package's prompt assembly, schema, output parsers
- Bump the package version
- Re-test with Gemini (different model — line-by-line citation behavior may differ from claude/codex)
That's an architectural change to the in-tree code-review-council package, not a YAML diff. It's also subject to the DAP rule about not running DAP autonomously against rafeekpro/dap (DB-wipe risk per memory dap-self-fix-known-dangerous).
Path forward — investigate, do not auto-execute
Recommended steps (manual, NOT via DAP autonomous run):
- Read the in-tree package at
packages/code-review-council/. Identify where specialists are registered.
- Determine if Gemini's review output format supports the same
file:line citation contract the claude/codex council uses. If yes, the fan-out is mechanically possible. If no, this becomes "design a Gemini-specific line-by-line specialist."
- Author a Code Style specialist module in the package, modeled on the existing 6 specialists.
- Test on a no-op PR to dap before promoting.
- Ship via a normal PR authored manually (NOT autonomously by DAP).
Acceptance criteria (when work eventually happens)
packages/code-review-council/ has +1 specialist module for Code Style
- The package's CLI invokes it as part of the council
- Test PR on dap exercises it and produces file:line citations in the review output
- Existing 6 specialists' output unchanged
Out of scope
- Auto-shipping via DAP (rafeekpro/dap is on the DO-NOT-AUTO list)
- Changing the Gemini API key handling
- Migrating dap to claude-bridge or codex-bridge
Related
Summary — tracking issue, NOT a one-shot fix
This is a tracking issue for evaluating whether (and how) to add a line-by-line code-style review specialist to
rafeekpro/dap's AI review gate. It cannot be shipped via DAP as a one-shot the way the speacher / news-sentiment / cortex-project / cfd fan-out can, because dap's review architecture is fundamentally different.Why dap is different from the other 4 repos
The other 4 repos use
.github/workflows/copilot-review-required.yml— a single workflow file with aconst AGENTS = [...]JavaScript array embedded in agh scriptstep. Adding a new specialist there is a small YAML/JS edit.dap uses
.github/workflows/gemini-review.yml— a different workflow that:packages/code-review-council(an in-tree Python package —pip install -e ./packages/code-review-council)So fanning out the Code Style specialist to dap means:
packages/code-review-council/to add a Code Style specialist class/configThat's an architectural change to the in-tree code-review-council package, not a YAML diff. It's also subject to the DAP rule about not running DAP autonomously against
rafeekpro/dap(DB-wipe risk per memorydap-self-fix-known-dangerous).Path forward — investigate, do not auto-execute
Recommended steps (manual, NOT via DAP autonomous run):
packages/code-review-council/. Identify where specialists are registered.file:linecitation contract the claude/codex council uses. If yes, the fan-out is mechanically possible. If no, this becomes "design a Gemini-specific line-by-line specialist."Acceptance criteria (when work eventually happens)
packages/code-review-council/has +1 specialist module for Code StyleOut of scope
Related