PR: kynesyslabs/sdks#90
Branch: governance-roundtrip-fixtures → main
Head: 635a7616
What it does
Adds two missing fixtures to src/denomination/roundTripHash.test.ts:
networkUpgrade content (post-sign canonical shape) round-trips
networkUpgradeVote content (post-sign canonical shape) round-trips
Plus two trivial override modifier fixups on BroadcastFailedError.cause and TransportError.cause so release v4.0.3 compiles under TypeScript ≥ 5.6's stricter override checking.
Why
Governance content shapes were the only ones not exercised by the SDK↔node byte-equality round-trip test. The gap surfaced while debugging the propose hash mismatch on dev.node2 — without a round-trip fixture for governance content, the SDK side has no canonical guard against accidental drift in the byte shape it ships.
CI status
All green:
- Greptile Review: success
- SonarCloud Code Analysis: success
- CodeQL × 3: success
- CodeRabbit: no actionable comments
- Build: skipped (test-only)
AI feedback addressed
| Source |
Severity |
Issue |
Resolution |
| Greptile |
P2 |
as unknown as GCREdit cast was unnecessary in networkUpgrade fixture |
Replaced with satisfies GCREdit (commit 635a7616) |
| Greptile |
P2 |
Same in networkUpgradeVote fixture |
Replaced with satisfies GCREdit (commit 635a7616) |
Next step
Reviewer approval. mergeable=MERGEABLE. Zero merge risk — pure test-only change + TS6 build fixups.
PR: kynesyslabs/sdks#90
Branch:
governance-roundtrip-fixtures→mainHead:
635a7616What it does
Adds two missing fixtures to
src/denomination/roundTripHash.test.ts:networkUpgrade content (post-sign canonical shape) round-tripsnetworkUpgradeVote content (post-sign canonical shape) round-tripsPlus two trivial
overridemodifier fixups onBroadcastFailedError.causeandTransportError.causesorelease v4.0.3compiles under TypeScript ≥ 5.6's stricter override checking.Why
Governance content shapes were the only ones not exercised by the SDK↔node byte-equality round-trip test. The gap surfaced while debugging the propose hash mismatch on dev.node2 — without a round-trip fixture for governance content, the SDK side has no canonical guard against accidental drift in the byte shape it ships.
CI status
All green:
AI feedback addressed
as unknown as GCREditcast was unnecessary in networkUpgrade fixturesatisfies GCREdit(commit635a7616)satisfies GCREdit(commit635a7616)Next step
Reviewer approval. mergeable=MERGEABLE. Zero merge risk — pure test-only change + TS6 build fixups.