automatically detect and lint wrappers around log calls

[pohly]

When a wrapper functions accepts variadic arguments and passes them through to a log call, then the same rules as for that log call also apply to the wrapper.

logcheck previously side-stepped that issue by not allowing passing of unknown slices to log calls. #20 relaxed that.

[pohly]

As discussed in #20 (comment), something similar to printf-format checking should also be possible for log calls.

/triage accepted
/assign @jaythamke

[k8s-ci-robot]

@pohly: GitHub didn't allow me to assign the following users: jaythamke.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

As discussed in #20 (comment), something similar to printf-format checking should also be possible for log calls.

/triage accepted
/assign @jaythamke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[pohly]

/triage accepted

[pohly]

@jaythamke: are you still interested in working on this?

I was reminded again of this when re-activating kubernetes/kubernetes#121989. The new(ish) HandleErrorWithContext accepts key/value pairs:

utilruntime.HandleErrorWithContext(ctx, err, "Sync failed", "key", cKey)

It would be nice to get linting for that.

[pohly]

Related: go-simpler/sloglint#22

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted