Any simple way to change faces in moe-theme permanently?

[BooAA]

Hi, thanks for making such an awesome theme.

Personally I don' like the setting of flycheck-error face . I prefered the default flycheck faces (underline, wave, red), so I tried to reset it. By the way, I have another keybinding which let me to switch between moe-light and moe-dark easily.

However, everytimes I use load-theme to switch between moe-light and moe-dark, emacs seems to laod the source file ( moe-light.el or moe-dark.el) again, and the flycheck-error face will be set to the value defined in moe-theme but not my personal setting.

I haved make a very brute solution , like this:

(global-set-key [menu] (lambda ()
			(interactive)
			(if (equal moe-theme-which-enabled 'dark)
                             (progn
                               (load-theme 'moe-light t nil)
                               (custom-theme-set-faces 'moe-light
                                                       '(flycheck-error ((t (:underline (:color "black" :style wave)))))))
                           (progn
                               (load-theme 'moe-dark t nil)
                               (custom-theme-set-faces 'moe-dark
                                                       '(flycheck-error ((t (:underline (:color "Red1" :style wave))))))))))

which just set the value again after relaod the theme. I'm looking for a more elegant or reliable way to do this, hoping that you can give me some advice.

[kuanyui]

Sorry I use Emacs 99.9% in terminal, so changed the default face of flycheck (invisible on some terminal environment)

You are mostly on the right way. Currently so far as I know there's no better way to do this. I think any other theme of Emacs has same problem. I'm planning to add more customization (and deprecated some crap functions) for moe-theme 2.0 (on dev branch), maybe I can let user add hook to them.

Last but not least, you don't need to worry about writing in English. You have expressed your question in English clearly. We are not master in British literature so no one should blame your English ability (If so, just ignore such idiot). In fact, I think it is quite impolite and annoying to write in Chinese in an international community, though it seems that more and more guys like to do that recently.

[BooAA]

Thanks, I'm looking forward to the "moe-theme2.0" .

Also. I have removed the Chinese part to make the layout cleaner.

[dakra]

@BooAA I think what a lot of people (including me) do is fork this repository and make your changes there.
Normally changes in this theme are rare and few and should be easy to rebase on your fork.

[BooAA]

@dakra Actually I forked this repo 2 days ago. Thanks for your suggestion.