language now being overridden

[dilinger]

In invio 1.x, I think that I set "english" as my language.. and invoices that were sent went out in english. Now, however, invoices to people in different countries seem to be automatically translated, and I can't find anywhere in settings for configuring a language. For example, I'm in the US, and I'm invoicing someone in Germany. All of my past invoices to them (using invio 1.x) were in english; "Invoice details", "description", the actual description that I'd write..

As of invio 2.0.0, those invoices now have descriptions in German; "Rechnungsdetails", "Beschreibung" (of course the description that I'd write is in english). When I click on an invoice from the invoices page, it's in english; but when I generate an HTML or PDF invoice, it switches to German.

I suggest each customer, along with their normal information (country code, tax id, etc) get a "language" field pull down that defaults to a language based on country code, but can be changed. And then when viewing invoices, the language that is configured for that user is what is displayed AND the same language is used when generating html/pdf invoices (so it's consistent).

[Bouni]

I have some translation issues as well.

I suggested in #78 that the invoice should be in the language of the customer, which works sometimes ...

• Customer has its country code set to NL -> Invoice is in dutch
• Customer has its country code set to DE -> Invoice is in german
• Customer has its country code set to PT -> Invoice is in portuguese
• Customer has its country code set to US -> Invoice is in german, but should be english (maybe its german as a fallback because my Invio is set to german!?)
• Customer has its country code set to SE -> Invoice is in german, fallback because my Invio is set to german!?

To me I would like to be able to set the fallback language to english because that is what would worjk for most customers

[Bouni]

I think the issue is in this block of code

https://github.com/kittendevv/Invio/blob/main/backend/src/routes/admin.ts#L157-L185

This tries in resolveInvoiceRenderLocale

1. get the invoice locale

This branch never works because the invoice locale is never fetched from the database: https://github.com/kittendevv/Invio/blob/main/backend/src/controllers/invoices.ts#L548-L553
The db column is there, but there is no UI to populate it.

2. the customer country code

Here only a fixed set of country codes return a locale.

  if (code === "DE" || code === "AT" || code === "CH") return "de";
  if (code === "NL" || code === "BE") return "nl";
  if (code === "PT" || code === "BR") return "pt-br";

4. the invio settings locale

as a fallback it returns en

So It only needs the UI to set a invoice locale and teh extension of the SQL query in order to allow per invoice languages.