Fdo Secret Service GUI tests crash on Qt6

[varjolintu]

Have you searched for an existing issue?

• Yes, I tried searching and reviewed the pinned issues

Brief Summary

When running GUI tests with Qt6, some Linux distributions fail with the FDO Secret Service test. One of the tests (testCollectionDeleteConcurrent) crashes. It looks like two threads are doing things simultaneously, deleting pointers when those are still in use. The issue needs to be investigated properly. Quite possibly the FDO Service needs some refactors.

A few relevant comments from the Qt6 PR:
#11651 (comment)
#11651 (comment)

Steps to Reproduce

1. Use -DWITH_GUI_TESTS=ON
2. Run testguifdosecrets
3. Observe a crash

Expected Versus Actual Behavior

No response

KeePassXC Debug Information

KeePassXC - Version 2.8.0-snapshot
Build Type: Snapshot
Revision: 1cc4131
Distribution: Native

Qt 6.11.0

Operating System

Linux

Linux Desktop Environment

Other

Linux Windowing System

X11/Wayland

[WhyNotHugo]

They also crash for me on non-Wayland on Alpine. Inside a clean chroot, running tests with:

QT_QPA_PLATFORM=xcb xvfb-run -a ctest --test-dir build -j1

Full build log: https://gist.github.com/WhyNotHugo/2d67cd222604b1edae8c644d8fc31b3c

[varjolintu]

@WhyNotHugo Thanks. It was just my hunch that the crash could be related to Wayland.

[michaelk83]

Quite possibly the FDO Service needs some refactors.

The trace in #11651 (comment) suggests this might be covered by #8591

[uro666]

@varjolintu > It was just my hunch that the crash could be related to Wayland.

Just to clarify and verify that my prior report in the other issue that the testguifdosecrets test are crashing for me in xlibre/kwin in a clean mock chroot with this test env setup:

LANG=C.UTF-8 \
XDG_SESSION_TYPE=tty \
QT_QPA_PLATFORM=xcb \
CTEST_OUTPUT_ON_FAILURE=ON \
xvfb-run --auto-servernum ctest -VV --test-dir=build 

When I switch my test setup to using wayland/kwin in a clean mock chroot I get the same test failure with this test env setup:

LANG=C.UTF-8 \
XDG_SESSION_TYPE=tty \
QT_QPA_PLATFORM=wayland \
CTEST_OUTPUT_ON_FAILURE=ON \
wlheadless-run -c kwin -- ctest -VV --test-dir=build --debug

I think we can probably rule it out being relating to compositors.

[uro666]

I ran a clean mock buld of 7c7ca45 from develop branch with fd22a32 applied on top and I am getting the same test fail in TestGuiFdoSecrets:

46: Received signal 11 (SIGSEGV), code SEGV_MAPERR, at instruction address 0x000055ab13ba8b0b, accessing address 0x0000000000000004
46:          testCollectionDeleteConcurrent function time: 290ms, total time: 10039ms
46/46 Test #46: testguifdosecrets ................Testing testguifdosecrets ... ***Failed   10.08 sec

[Taijian]

Using the same setup of develop-latest + fd22a32 applied on top, I get the following:

47/47 Testing: testguifdosecrets
47/47 Test: testguifdosecrets
Command: "/usr/bin/dbus-run-session" "--config-file" "/build/keepassxc-qt6/src/keepassxc/tests/gui/../data/dbus/session.conf" "--" "sh" "-c" "exec ./$0" "testguifdosecrets"
Directory: /build/keepassxc-qt6/src/build/tests/gui
"testguifdosecrets" start time: May 05 09:24 UTC
Output:

********* Start testing of TestGuiFdoSecrets *********
Config: Using QtTest library 6.11.0, Qt 6.11.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 16.1.1 20260430), arch unknown
PASS : TestGuiFdoSecrets::initTestCase()
PASS : TestGuiFdoSecrets::testServiceEnable()
PASS : TestGuiFdoSecrets::testServiceEnableNoExposedDatabase()
PASS : TestGuiFdoSecrets::testServiceSearch()
PASS : TestGuiFdoSecrets::testServiceSearchBlockingUnlock()
PASS : TestGuiFdoSecrets::testServiceSearchBlockingUnlockMultiple()
PASS : TestGuiFdoSecrets::testServiceSearchForce()
PASS : TestGuiFdoSecrets::testServiceUnlock()
PASS : TestGuiFdoSecrets::testServiceUnlockDatabaseConcurrent()
PASS : TestGuiFdoSecrets::testServiceUnlockItems()
PASS : TestGuiFdoSecrets::testServiceUnlockItemsIncludeFutureEntries()
PASS : TestGuiFdoSecrets::testServiceLock()
PASS : TestGuiFdoSecrets::testServiceLockConcurrent()
PASS : TestGuiFdoSecrets::testSessionOpen()
PASS : TestGuiFdoSecrets::testSessionClose()
PASS : TestGuiFdoSecrets::testCollectionCreate()
PASS : TestGuiFdoSecrets::testCollectionDelete()
Received signal 11 (SIGSEGV), code SEGV_MAPERR, at instruction address 0x00007f17934221e6, accessing address 0x0000000000000008
testCollectionDeleteConcurrent function time: 342ms, total time: 10722ms

Test time = 10.76 sec

Test Failed.
"testguifdosecrets" end time: May 05 09:24 UTC
"testguifdosecrets" time elapsed: 00:00:10