Generated Makefile netsim: section problems

[magedelmalah]

• Playbook for Ansible + NSO Generator version: NA + 4.7.4.3
• Python version: 3.6.8
• Operating System: Linux Ubuntu 18.04

Description

The generated Makefile netsim: section has two issues
1- The generated line to create and add devices has NED name type mistake for ios-xr as below:

The wrong one: "cisco-ios-xr"
netsim:
ncs-netsim create-device cisco-ios-xr xr0
ncs-netsim add-device cisco-ios-xr xr1
ncs-netsim add-device cisco-ios-xr xr2
ncs-netsim add-device cisco-ios-xr xr3
ncs-netsim add-device cisco-ios-xr xr4

The right one : "cisco-iosxr"
netsim:
ncs-netsim create-device cisco-iosxr xr0
ncs-netsim add-device cisco-iosxr xr1
ncs-netsim add-device cisco-iosxr xr2
ncs-netsim add-device cisco-iosxr xr3
ncs-netsim add-device cisco-iosxr xr4

2- I have cisco-ioxr and juniper-junos in my network but the generated Makefile netsim: section has only cisco-ios-xr and juniper-junos devices are missing

What I Did

below the manually added lines

netsim:
ncs-netsim create-device cisco-iosxr xr0
ncs-netsim add-device cisco-iosxr xr1
ncs-netsim add-device cisco-iosxr xr2
ncs-netsim add-device cisco-iosxr xr3
ncs-netsim add-device cisco-iosxr xr4
ncs-netsim add-device juniper-junos jun0
ncs-netsim add-device juniper-junos jun1
ncs-netsim add-device juniper-junos jun2
ncs-netsim add-device juniper-junos jun3
ncs-netsim add-device juniper-junos jun4