From 9f430971012c0307c3ff966d13e465a6a499a293 Mon Sep 17 00:00:00 2001 From: kaypee90 Date: Sun, 30 Nov 2025 23:26:48 -0500 Subject: [PATCH 1/2] Add comprehensive type hints to worker initialization and queue handling --- zebrok/worker.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/zebrok/worker.py b/zebrok/worker.py index 182cf99..8abd796 100644 --- a/zebrok/worker.py +++ b/zebrok/worker.py @@ -26,7 +26,9 @@ class TaskQueueWorker: Listens and receives tasks and uses a task runner to execute them """ - def __init__(self, connection, runner) -> None: + def __init__( + self, connection: BaseSocketConnection, runner: BaseTaskRunner + ) -> None: self.slaves: List[Any] = [] self.connection = connection self.socket = self.connection.socket @@ -79,7 +81,7 @@ def stop(self) -> None: self.current_slave = 0 self.connection.close() - def add_slave(self, worker) -> None: + def add_slave(self, worker: Any) -> None: """ Adds a slave worker to a master worker """ @@ -159,7 +161,9 @@ def _initialize_workers(self) -> None: master_worker, ) - def _create_master_worker(self, *settings: Any): + def _create_master_worker( + self, *settings: Any + ) -> Tuple[BaseSocketConnection, TaskQueueWorker]: """ Creates the main worker """ @@ -172,8 +176,8 @@ def _initialize_slave_workers( max_workers: int, host: str, port: int, - master_socket: Any, - master_worker: Any, + master_socket: BaseSocketConnection, + master_worker: TaskQueueWorker, ) -> None: """ Creates worker threads as slaves to be associated with the main worker From 62e4f4ee38357689a22f2d23a93422d968b165a0 Mon Sep 17 00:00:00 2001 From: kaypee90 Date: Sun, 30 Nov 2025 23:35:47 -0500 Subject: [PATCH 2/2] Fix add_slave parameter name and socket handling --- zebrok/worker.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/zebrok/worker.py b/zebrok/worker.py index 8abd796..62c4c67 100644 --- a/zebrok/worker.py +++ b/zebrok/worker.py @@ -81,11 +81,11 @@ def stop(self) -> None: self.current_slave = 0 self.connection.close() - def add_slave(self, worker: Any) -> None: + def add_slave(self, slave_socket: Any) -> None: """ - Adds a slave worker to a master worker + Adds a slave worker socket to a master worker """ - self.slaves.append(worker) + self.slaves.append(slave_socket) class WorkerInitializer: