Build error

[htzh]

I have the following build error:

File "macro_main.ml", line 1, characters 0-12:
Error: Unbound module Odyl_main

It is probably configuration issue with OMake, but unfortunately I don't know OMake at all. camlp5 is installed and "-I" points to the correct directory.

[ANogin]

I am guessing the version of camlp5 you build did not install odyl_main.cmi / odyl_main.mli into /home/.../.opam/system/lib/camlp5 - you would need to either change tweak the install part of camlp5 build, or copy these two files our of the camlp5 build manually.

[htzh]

Thanks for the response. That moved the build further along (I also needed to copy over odyl_main.cmx, pcaml.cmx and reloc.cmx) till I hit the following:

- build mllib ctime.cmx
+ ocamlopt.opt -warn-error Aez-3-7-29-37-44-45-50 -w Aez-3-7-29-37-44-45-50 -thread -inline 3 -pp ../lib/macropp -I . -I /usr/lib/ocaml/compiler-libs -I ../libmojave/stdlib -I ../libmojave/util -I ../libmojave/unix -c ctime.ml
File "ctime.ml", line 1:
Error: I/O error: /tmp/ocamlpp61f926c2b78539bc920fa76c8b41cbde: File exists
*** omake: 1999/4146 targets are up to date
*** omake: failed (1.97 sec, 0/559 scans, 27/614 rules, 34/445 digests)
*** omake: targets were not rebuilt because of errors:
   mllib/ctime.cmx
      depends on: mllib/ctime.ml
   mllib/ctime.o
      depends on: mllib/ctime.ml

I don't understand the complaint about /tmp/... file exsits. As far as I can tell it doesn't (maybe removed by omake). I am building on ubuntu 18.04 under wsl.

[ANogin]

This is very weird - sounds like a clash in temporary file name... Is this error reproducible if you try building again? Does it still happen with non-parallel (-j1) build?

[htzh]

The tmp file error was repeatable though each time with a different file name. However your suggestion of non-parallel build (-j1) worked and moved me past that hump. After copying over pa_o.cmo and quotation.cmx I was able to get to the following:

- build support/display base_dform.cmoz
+ Shell.prlcomp(lib/camlp5n -o base_dform.ppo base_dform.ml)

----------------------------------
Parse error in entry [con_params], rule:
  [ "["; LIST0 con_param* SEP ","; "]" ]
----------------------------------

File "base_dform.ml", line 204, characters 29-30:              ] 03022 / 04147 While expanding quotation "con":
Parse error: [con_param] expected after '[' (in [con_params])
*** omake: 3025/4147 targets are up to date
*** omake: failed (8.21 sec, 86/667 scans, 60/1362 rules, 171/590 digests)
*** omake: targets were not rebuilt because of errors:
   support/display/base_dform.cmoz
      depends on: support/display/base_dform.ml
   support/display/base_dform.ppo
      depends on: support/display/base_dform.ml

[htzh]

I wonder if this is config related. Omake tried to probe for the browsers during the configuration phase but none was found (I am building under wsl). Maybe there is some feature that I need to turn off.

[ANogin]

I am pretty sure it's not about browsers. What version of ocaml and camlp5 are you using? MetaPRL is very sensitive to that - I believe Jason had updated things to work with 4.05 a couple of years ago, and it's quite likely it would only work with that particular version...

[htzh]

I am on ocaml 4.05 and camlp5 7.06. I did have to add 7.06 to the config file (it topped out at 7.03 which I assumed was what was available back then). If you think the failure may be camlp5 related I can downgrade to camlp5 7.03 and retry.

[htzh]

I tried 7.03 and there is actually regression:

File "infix.ml", line 46, characters 2-21:
Error: Unbound value Grammar.safe_extend
*** omake: 2569/4147 targets are up to date

I checked and Grammar.safe_extend is not in grammar.mli for version 7.03, but it is in the master on github.

[ANogin]

This is the stuff that Jason modified two years ago when he added OCaml 4.05 support - I guess, unless Jason is around to respond to this thread, you will have to figure out yourself which version of camlp5 might work here...

[ANogin]

But wait, where is Grammar.safe_extend coming from? I am seeing Grammar.extend on filter/base/infix.ml:46

[htzh]

Yes that is really weird. Somehow

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   OMakefile_common
        modified:   filter/base/infix.ml

no changes added to commit (use "git add" and/or "git commit -a")

diff --git a/filter/base/infix.ml b/filter/base/infix.ml
index 4664b6195..72efbc01c 100644
--- a/filter/base/infix.ml
+++ b/filter/base/infix.ml
@@ -43,54 +43,64 @@ let prefix_name op = "prefix_" ^ op
  * Add an infix keyword.
  *)
 let add_infix (keyword : string) =
-  Grammar.extend
+  Grammar.safe_extend
     (let _ = (expr : 'expr Grammar.Entry.e) in
-     [Grammar.Entry.obj (expr : 'expr Grammar.Entry.e),
-      Some (Gramext.Level "expr1"),
-      [Some "expr1", Some Gramext.LeftA,
-       [[Gramext.Sself; Gramext.Stoken ("", keyword); Gramext.Sself],
-        Gramext.action
-          (fun (e2 : 'expr) (op : string) (e1 : 'expr) (_loc : Ploc.t) ->
-             (MLast.ExApp
-                (_loc,
-                 MLast.ExApp
-                   (_loc, MLast.ExLid (_loc, Ploc.VaVal (prefix_name op)),
-                    e1),
-                 e2) :
-              'expr))]]])

Does something in the build process change the source code?! I am certainly incapable of this change.

[ANogin]

Yes, that looks like a bug in Jason's 4.05 change - the file is a generated file and needs to be removed from the repository, added to .gitignore, and added to the clean command in the corresponding OMakefile.

[htzh]

I rechecked out the file so the changes are abandoned and now I am back to about the same place with a similar failure as in 7.06 (slightly further along at 3075 instead of 3025):

- build support/display comment.cmoz
+ Shell.prlcomp(lib/camlp5n -o comment.ppo comment.ml)

----------------------------------
Parse error in entry [con_params], rule:
  [ "["; LIST0 con_param* SEP ","; "]" ]
----------------------------------

File "comment.ml", line 481, characters 33-34:
While expanding quotation "con":
Parse error: [con_param] expected after '[' (in [con_params])
*** omake: 3078/4149 targets are up to date
*** omake: failed (13.67 sec, 118/684 scans, 116/1374 rules, 189/631 digests)
*** omake: targets were not rebuilt because of errors:
   support/display/comment.cmoz
      depends on: support/display/comment.ml
   support/display/comment.ppo
      depends on: support/display/comment.ml

[ANogin]

I do not know enough about camlp5 or Jason's ocaml 4.05 changes to help you further, sorry.

[htzh]

I removed the infix.ml file and regenerated and it is identical to the one checked into the repo (by mistake). So at least I now know that I am using the same version of camlp5 (as I assume it is unlikely for the generated file to be the same otherwise). I also omake clean and omake -j1 and now I get the same error as #1 (comment) so it appears that the minor difference in which file triggers the parse error is an artifact of the build order.