From 2f3b34421cbfacc9097ddae8988f37317388dc7a Mon Sep 17 00:00:00 2001 From: Nicolas Date: Sat, 15 Nov 2025 01:19:35 +0100 Subject: [PATCH] fix(clickhouse_client): support all table engines in schema generation Remove MergeTree-only filter from get_database_tables() to include tables with other engine types (S3, File, etc.) in schema.sql output. Previously, the query filtered tables to only include those with 'MergeTree' in the engine name using: AND position('MergeTree' IN engine) > 0 This caused S3 tables and other non-MergeTree engines to be excluded from schema.sql generation, even though they were valid tables that should be tracked. The fix removes this restrictive filter while still excluding MaterializedView and Dictionary engines, which have their own dedicated methods. Fixes schema.sql generation for S3-backed tables and other engine types. --- src/houseplant/clickhouse_client.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/houseplant/clickhouse_client.py b/src/houseplant/clickhouse_client.py index 13479c6..1453b86 100644 --- a/src/houseplant/clickhouse_client.py +++ b/src/houseplant/clickhouse_client.py @@ -199,7 +199,6 @@ def get_database_tables(self): name FROM system.tables WHERE database = currentDatabase() - AND position('MergeTree' IN engine) > 0 AND engine NOT IN ('MaterializedView', 'Dictionary') AND name != 'schema_migrations' ORDER BY name