Update prefs window, app icons, and UI icon / Add Cmd+W to close Prefs and About windows#4
Merged
Merged
Conversation
- Add Cmd+W handling to PrefsWindow to close the preferences window - Reduce the Saved Networks pane size from 620x420 to 480x320. - Change the router SF Symbol to "wifi.router" in NetworkDetailsDashboard - Update AppIcon.appiconset with missing image sizes.
Author
|
@joshcalvert47 |
- Move Credits.rtf into Base.lproj and add localized Credits.rtf files (ar, cs, de, el, en, es, fr, id, it, ko, pl, pt-BR, pt-PT, ro, ru, tr, uk, vi, zh-Hans) - Update Xcode project.pbxproj to use a PBXVariantGroup for Credits.rtf and adjust build file / group ordering - Add Cmd+W handling to close the About window in StatusMenuBase.swift.
perez987
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update router icon: replace the router detail SF Symbol from "router" to "wifi.router" in the
NetworkDetailsDashboard(router icon not foundmessage in console).Add Cmd+W to close prefs and about windows.
Update app icons: complete AppIcon.appiconset with missing imagesizes.
Localize Credits.rtf files.
Resize networks prefs: reduce the Saved Networks preferences window from 620x420 to 540x320 to better match the view content; switching between the Networks and Debug tabs is smoother this way.