Problem with PopLocalFrame() being called after an exception

[erhan-mengusoglu]

jffi/jni/jffi/Exception.c

Line 51 in 774a37f

(*env)->PopLocalFrame(env, NULL);

I think this line need to be moved to before the if statement.

[erhan-mengusoglu]

Or, alternatively remove lines 46 and 51 as nothing is changed on the stack, only FindClass is being called.

[erhan-mengusoglu]

This issue has caused a crash when the exception is not handled. Here is the stack trace:

at com/kenai/jffi/Foreign.dlsym(Native Method) at com/kenai/jffi/Library.getSymbolAddress(Library.java:188) at jnr/ffi/provider/jffi/NativeLibrary.getSymbolAddress(NativeLibrary.java:65) at jnr/ffi/provider/jffi/NativeLibrary.findSymbolAddress(NativeLibrary.java:74) at jnr/ffi/provider/jffi/AsmLibraryLoader.generateInterfaceImpl(AsmLibraryLoader.java:141) at jnr/ffi/provider/jffi/AsmLibraryLoader.loadLibrary(AsmLibraryLoader.java:87) at jnr/ffi/provider/jffi/NativeLibraryLoader.loadLibrary(NativeLibraryLoader.java:44) at jnr/ffi/LibraryLoader.load(LibraryLoader.java:420) at jnr/enxio/channels/Native$SingletonHolder.(Native.java:77) at jnr/enxio/channels/Native.libc(Native.java:89) at jnr/enxio/channels/Native.write(Native.java:137) at jnr/unixsocket/impl/Common.write(Common.java:105) at jnr/unixsocket/impl/AbstractNativeSocketChannel.write(AbstractNativeSocketChannel.java:82) at jnr/unixsocket/UnixSocketChannel.write(UnixSocketChannel.java:264) at java/nio/channels/Channels.writeFullyImpl(Channels.java:74) at java/nio/channels/Channels.writeFully(Channels.java:93) (entered lock: java/lang/Object@0x00000000FF2B2080, entry count: 1) at java/nio/channels/Channels$1.write(Channels.java:171) (entered lock: java/nio/channels/Channels$1@0x00000000FF2D7F18, entry count: 1) at java/io/BufferedOutputStream.flushBuffer(BufferedOutputStream.java:81(Compiled Code)) at java/io/BufferedOutputStream.flush(BufferedOutputStream.java:142(Compiled Code)) (entered lock: java/io/BufferedOutputStream@0x00000000FF2D7EF8, entry count: 1) at

...

JNI error in PopLocalFrame: This function cannot be called when an exception is pending JVMJNCK077E Error detected in com/kenai/jffi/Foreign.dlsym(JLjava/lang/String;)J JVMJNCK024E JNI error detected. Aborting.The messages are caused by incorrect JNI usage in the native jffi library path (com/kenai/jffi/Foreign.dlsym).