Skip to content

Is 142840cfed3d15bbdc76c11178445868fb3259c5 known to be broken? #45

@assarbad

Description

@assarbad

Hi Jim,

I was trying to rebuild the code from 142840c, but it fails with different errors. The errors for MSVC 10.0, 12.0 and 14.0 give me:

link /nologo /map /OUT:build\urelease\makensis\makensis.exe build\urelease\makensis\build.obj build\urelease\makensis\clzma.obj build\urelease\makensis\crc32.obj build\urelease\makensis\DialogTemplate.obj build\urelease\makensis\dirreader.obj build\urelease\makensis\fileform.obj build\urelease\makensis\growbuf.obj build\urelease\makensis\icon.obj build\urelease\makensis\lang.obj build\urelease\makensis\lineparse.obj build\urelease\makensis\makenssi.obj build\urelease\makensis\manifest.obj build\urelease\makensis\mmap.obj build\urelease\makensis\Plugins.obj build\urelease\makensis\ResourceEditor.obj build\urelease\makensis\ResourceVersionInfo.obj build\urelease\makensis\script.obj build\urelease\makensis\ShConstants.obj build\urelease\makensis\strlist.obj build\urelease\makensis\tokens.obj build\urelease\makensis\tstring.obj build\urelease\makensis\util.obj build\urelease\makensis\validateunicode.obj build\urelease\makensis\winchar.obj build\urelease\makensis\writer.obj build\urelease\makensis\ttf.obj build\urelease\makensis\bzip2\blocksort.obj build\urelease\makensis\bzip2\bzlib.obj build\urelease\makensis\bzip2\compress.obj build\urelease\makensis\bzip2\huffman.obj build\urelease\makensis\7zip\7zGuids.obj build\urelease\makensis\7zip\7zip\Common\OutBuffer.obj build\urelease\makensis\7zip\7zip\Common\StreamUtils.obj build\urelease\makensis\7zip\7zip\Compress\LZ\LZInWindow.obj build\urelease\makensis\7zip\7zip\Compress\LZMA\LZMAEncoder.obj build\urelease\makensis\7zip\7zip\Compress\RangeCoder\RangeCoderBit.obj build\urelease\makensis\7zip\Common\Alloc.obj build\urelease\makensis\7zip\Common\CRC.obj build\urelease\makensis\zlib\deflate.obj build\urelease\makensis\zlib\trees.obj
build.obj : error LNK2019: unresolved external symbol __imp__wsprintfW referenced in function "public: __thiscall CEXEBuild::CEXEBuild(void)" (??0CEXEBuild@@QAE@XZ)
script.obj : error LNK2001: unresolved external symbol __imp__wsprintfW
build.obj : error LNK2019: unresolved external symbol __imp__SendMessageW@16 referenced in function "private: void __cdecl CEXEBuild::ERROR_MSG(wchar_t const *,...)const " (?ERROR_MSG@CEXEBuild@@ABAXPB_WZZ)
DialogTemplate.obj : error LNK2001: unresolved external symbol __imp__SendMessageW@16
build.obj : error LNK2019: unresolved external symbol __imp__CharNextW@4 referenced in function "private: int __thiscall CEXEBuild::preprocess_string(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > &,wchar_t const *,unsigned short)" (?preprocess_string@CEXEBuild@@AAEHAAV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@PB_WG@Z)
script.obj : error LNK2001: unresolved external symbol __imp__CharNextW@4
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__CreateCompatibleDC@4 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__CreateFontIndirectW@4 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__DeleteDC@4 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__DeleteObject@4 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__GetTextExtentPoint32W@16 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__SelectObject@8 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__GetObjectW@12 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__DestroyWindow@4 referenced in function "public: void __thiscall CDialogTemplate::DlgUnitsToPixels(short &,short &)" (?DlgUnitsToPixels@CDialogTemplate@@QAEXAAF0@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__CreateDialogIndirectParamW@20 referenced in function "public: struct HWND__ * __thiscall CDialogTemplate::CreateDummyDialog(void)" (?CreateDummyDialog@CDialogTemplate@@QAEPAUHWND__@@XZ)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__GetDC@4 referenced in function "public: struct tagSIZE __thiscall CDialogTemplate::GetStringSize(unsigned short,wchar_t *)" (?GetStringSize@CDialogTemplate@@QAE?AUtagSIZE@@GPA_W@Z)
DialogTemplate.obj : error LNK2019: unresolved external symbol __imp__MapDialogRect@8 referenced in function "public: void __thiscall CDialogTemplate::DlgUnitsToPixels(short &,short &)" (?DlgUnitsToPixels@CDialogTemplate@@QAEXAAF0@Z)
makenssi.obj : error LNK2019: unresolved external symbol __imp__IsWindow@4 referenced in function _wmain
script.obj : error LNK2019: unresolved external symbol __imp__CharPrevW@8 referenced in function __catch$?doCommand@CEXEBuild@@AAEHHAAVLineParser@@@Z$2
script.obj : error LNK2019: unresolved external symbol _GetFileVersionInfoSizeW@8 referenced in function __catch$?doCommand@CEXEBuild@@AAEHHAAVLineParser@@@Z$8
util.obj : error LNK2001: unresolved external symbol _GetFileVersionInfoSizeW@8
script.obj : error LNK2019: unresolved external symbol _GetFileVersionInfoW@16 referenced in function __catch$?doCommand@CEXEBuild@@AAEHHAAVLineParser@@@Z$8
util.obj : error LNK2001: unresolved external symbol _GetFileVersionInfoW@16
script.obj : error LNK2019: unresolved external symbol _VerQueryValueW@16 referenced in function __catch$?doCommand@CEXEBuild@@AAEHHAAVLineParser@@@Z$8
util.obj : error LNK2001: unresolved external symbol _VerQueryValueW@16
build\urelease\makensis\makensis.exe : fatal error LNK1120: 19 unresolved externals
scons: building terminated because of errors.

MSVC 8.0 gives a compiler error about unordered_map (which I saw would be in Boost or in newer Visual C++ versions):

Source\tokens.cpp(26) : fatal error C1083: Cannot open include file: 'unordered_map': No such file or directory
scons: building terminated because of errors.

Is this a known issue with a known workaround? Or am I on my own in all of these cases? From how I see it, the newer VC versions just need some SDK import libs added. I need to read up in the SCons documentation as I am unfamiliar with it.

Thanks and best regards.

unsis-build-logs.zip

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions