From 90de2ca79581d04e9beca0c4af100f14aa4e61d9 Mon Sep 17 00:00:00 2001
From: Jeff Garzik <jgarzik@pobox.com>
Date: Wed, 4 Mar 2026 15:11:25 +0000
Subject: [PATCH] fix: resolve ESLint errors in config, server, and
 CaddyService

- Use nullish coalescing where safe, suppress where || is intentional
- Replace `as number` cast with Number() conversion in server.ts
- Use T[] array syntax instead of Array<T> in CaddyService
- Add explicit Record type to fix no-unnecessary-condition lint error

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/config.ts                | 2 +-
 src/server.ts                | 2 +-
 src/services/CaddyService.ts | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/config.ts b/src/config.ts
index af89e94..b397c59 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -100,7 +100,7 @@ export function getConfig(): AppConfig {
     proxyAdminToken,
     adminPassword,
     sessionExpiryMs: getEnvIntOrDefault('SESSION_EXPIRY_MS', 24 * 60 * 60 * 1000),
-    publicHost: process.env.PUBLIC_HOST?.trim() || null,
+    publicHost: process.env.PUBLIC_HOST?.trim() || null, // eslint-disable-line @typescript-eslint/prefer-nullish-coalescing -- intentionally treats empty string as null
     caddyEnabled: process.env.CADDY_ENABLED === 'true',
   };
 
diff --git a/src/server.ts b/src/server.ts
index d302f99..abdde8a 100644
--- a/src/server.ts
+++ b/src/server.ts
@@ -365,7 +365,7 @@ export async function buildServer(): Promise<FastifyInstance> {
   if (config.caddyEnabled && config.publicHost) {
     const runningBots = listBots()
       .filter(b => b.status === 'running' && b.port != null)
-      .map(b => ({ hostname: b.hostname, port: b.port as number }));
+      .map(b => ({ hostname: b.hostname, port: Number(b.port) }));
     const restored = await getCaddy(config.publicHost).restoreRoutes(
       runningBots, BOT_INTERNAL_PORT, server.log,
     );
diff --git a/src/services/CaddyService.ts b/src/services/CaddyService.ts
index 5292d06..799f8b9 100644
--- a/src/services/CaddyService.ts
+++ b/src/services/CaddyService.ts
@@ -47,7 +47,7 @@ export class CaddyService {
     try {
       const container = this.docker.getContainer(containerName);
       const info = await container.inspect();
-      const networks = info.NetworkSettings.Networks;
+      const networks: Record<string, { IPAddress: string } | undefined> = info.NetworkSettings.Networks;
       const networkInfo = networks[this.networkName];
 
       if (!networkInfo) {
@@ -147,7 +147,7 @@ export class CaddyService {
    * @returns Number of routes successfully restored
    */
   async restoreRoutes(
-    bots: Array<{ hostname: string; port: number }>,
+    bots: { hostname: string; port: number }[],
     internalPort: number,
     logger: { info: (msg: string | object, ...args: unknown[]) => void; warn: (msg: string | object, ...args: unknown[]) => void },
   ): Promise<number> {