Settings Saved message shown twice when placing the options under Settings page

[thnilsen]

When using parent_slug => options-general.php to get the options page to show up under the standard Settings menu, the library will cause the "Settings Saved" message to be shown twice when saving the form.

If using parent_slug => tools.php it works as expected and only shows the "Settings saved" message once.

[jeremyHixon]

Odd. I'll look into it soon.

…

On Fri, Jan 14, 2022 at 6:46 PM Thomas Nilsen ***@***.***> wrote: When using parent_slug => options-general.php to get the options page to show up under the standard Settings menu, the library will cause the "Settings Saved" message to be shown twice when saving the form. [image: setting_saved_duplicated] <https://user-images.githubusercontent.com/10619272/149598882-c7fbd9ca-a6ca-4469-8551-b97a0997621e.png> If using parent_slug => tools.php it works as expected and only shows the "Settings saved" message once. — Reply to this email directly, view it on GitHub <#38>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAK6ZINAYNSXZ5UQOZJBZE3UWCYVBANCNFSM5MACUKZQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Jeremy Hixon WordPress and Web Developer ***@***.*** | jeremyhixon.com <https://wpeng.in/jeremyhixon/> Outstanding WordPress Hosting + 20% Off your first payment wpeng.in/jeremyhixon

[Cyrille37]

Yes, in build_menu_page() there are 2 calls to settings_errors().

I did not purpose a PR because I'm not sure of the right solution. For my need I've just removed the second call to settings_errors( $page_key ).