Problem
When reviewing a tree of PRs created with jj-spr, it can be hard to know where the tree starts, where the “leaf node” PRs are, and how everything connects in-between.
Proposal
When jj spr diff is used to create a new PR (or updates an existing one), it also creates/edits a comment at the top of that PR where it will render the immediate parent and children PRs of that PR for easy reference by reviewers.
Take an example - imagine a tree of PRs that looks like this:
The comment for PR #4 ("Consume FooService with BarService") on GitHub would be as follows:
**Parent PR:**
- #3
**Children PRs:**
- #5
- #6
These comments would need to be kept up-to-date by jj spr diff as PRs are rebased and moved around.
Note that this only shows immediate ancestor / descendant(s). While it would be possible to use indented bullets to show the full tree, I think that would probably be overkill?
Problem
When reviewing a tree of PRs created with jj-spr, it can be hard to know where the tree starts, where the “leaf node” PRs are, and how everything connects in-between.
Proposal
When
jj spr diffis used to create a new PR (or updates an existing one), it also creates/edits a comment at the top of that PR where it will render the immediate parent and children PRs of that PR for easy reference by reviewers.Take an example - imagine a tree of PRs that looks like this:
The comment for PR
#4("Consume FooService with BarService") on GitHub would be as follows:These comments would need to be kept up-to-date by
jj spr diffas PRs are rebased and moved around.Note that this only shows immediate ancestor / descendant(s). While it would be possible to use indented bullets to show the full tree, I think that would probably be overkill?