no $ipv6_dhcp_duid for IPv6 method 'auto'

[kbucheli]

Using current main branch I get the error

IPv6 method for connection 'upstream' is 'auto' but no $ipv6_dhcp_duid was supplied. (file: /srv/puppet/code/preprod/code/modules/networkmanager/manifests/ifc/connection.pp, line: 149, column: 7)

with below interface configuration:

networkmanager::ifc::connection {
  'upstream':
    ensure         => present,
    interface_name => 'ens4f0',
    ipv4_method    => 'manual',
    ipv4_address   => '10.10.110.57/24',
    ipv4_gateway   => '10.10.110.1',
}

This causes that the default ipv6_method auto is used, but the code to calculate ipv6.dhcp-duid expects a MAC address which is missing here.

I wonder why there should be a hard requirement for this setting, because the NetworkManager manual states:

When the property is unset, the global value provided for "ipv6.dhcp-duid" is used. If no global value is provided, the default "lease" value is assumed.

So I guess it would be OK to just leave that unset.

[jednoprsak]

It is connected to use case we had in our condition. I think Samuraiii is not going to change his approach. It is now completely on him cause he is still administrating that condition, but you can write some handsome pull request if you like.

Have a good time

Lukáš

[samuraiii]

The problem is that this module is aimed on the server management, and when you use the "default" the duid is RANDOM which breaks leasing the right ipv6 address from the dhcp server.
I will look into this later, right now I have lot of RL stuff going on.

[kbucheli]

The current implementation does kind of a fake LL DUID with the given $duid_prefix and the MAC address of the interface. This is a bit against the intention of RFC3315 which wants "one" stable DUID per machine, ideally over the full life. So LL would select just one MAC and store it and keep it for the rest of the life of the hardware. I thus wonder why setting ipv6.dhcp-duid to ll is not good enough for the server use case?

We are using this module for all kind of devices, from servers over workstations to laptops. So having an auto setting which fails by default is not really handy.

Would it be OK to have an option to set the default value on class level for ipv6.dhcp-duid to something else than auto?

[samuraiii]

Yes "ideally over the full life." is quite problematic definition.
We run quite a few compute nodes which do not have redundant HDDs so our approach is more "over the lifetime" than the NM approach which stores the data on HDD which fails more often than the NIC.

I am open to the change, in some more convenient way, I just do not have time to implement it right now .
This module is a child of our environment to cater our need for more universal tool than other network modules (usually RH or DEB focused config).
I am sorry but right now I have two new co-wokers to train, so I do not have time to look into it for at least next FEW months.