fix(document): streamDocFinalize skips final content when only one editor element is present

[jdmanring]

Problem

streamDocFinalize() in static/js/document.js (on develop) writes the final streamed document content behind a combined guard:

const textarea = document.getElementById('doc-editor-textarea');
const codeEl   = document.getElementById('doc-editor-code');
if (textarea && codeEl) {
  const finalContent = docs.get(oldId)?.content || '';
  textarea.value = finalContent;
  codeEl.textContent = finalContent + '\n';
}

If either element is absent when finalize runs — while switching document modes or rebuilding the editor panel — the whole block is skipped and the final content is never written to the element that IS present, leaving stale/empty text at the end of a stream. The streaming deltas write each element independently; only finalize couples them.

Origin (important — FORK-ONLY)

This code is not upstream-inherited. upstream-mirror's streamDocFinalize has no such block. The combined guard was introduced on develop by commit 67268d2b ("perf(oom): pre-apply safe pieces from upstream PR #4661"), which copied #4661's doc-finalize code as a stopgap — including the exact piece that upstream reviewer gprocunier later flagged as a bug in #4661's own review. So this is a fork-only fix to our develop stopgap; there is no upstream target (upstream #4661 fixes its own copy in 0b830f1).

Fix

Write each element independently, computing final content once:

const finalContent = docs.get(oldId)?.content || '';
if (textarea) textarea.value = finalContent;
if (codeEl) codeEl.textContent = finalContent + '\n';

Classification: fork-only (branch from develop; merge to develop).

[github-actions]

⚠️ Issue description is incomplete. Please update the following sections:

• Install Method — select how you installed Odysseus
• Operating System — select your OS
• Steps to Reproduce — must include at least one numbered or bulleted step
• Expected Behaviour — section is empty or too short
• Actual Behaviour — section is empty or too short

This comment is deleted automatically once all sections are complete.

[jdmanring]

Fixed on develop in 7588c611.

streamDocFinalize now writes each editor element independently:

const finalContent = docs.get(oldId)?.content || '';
if (textarea) textarea.value = finalContent;
if (codeEl) codeEl.textContent = finalContent + '\n';

Regression guard added (tests/test_document_stream_finalize_independent_write_js.py, source-assertion style matching the repo's *_js.py convention): verified it fails on the old combined-guard code and passes on the fix; node --check clean on the edited file.

Fork-only (the block exists only on develop via the 67268d2 #4661 stopgap, not in upstream-mirror), so closed on landing to develop per the fork workflow.