Crash after click Save and Quit

[Gmrkc]

Running on 64 bit Windows 10.0.26200.0 with 32313 MB RAM
Game Version: v1.22.3 (Stable)
13.06.2026 11:54:40: Critical error occurred in the following mod: smithingplus@1.9.0-rc.1
Loaded Mods: walkingsticklite@1.0.0, hardcorewaterforked@1.4.6, catchlivestock@0.2.4, clickuptorches@1.1.1, cutthefat@2.0.0, darcesdriftersredone@1.3.0, foodcrate@2.2.1, hydrateordiedrate@2.4.12, immersivemining@0.2.22, manualdishes@0.1.2, manualdough@1.1.8, moretorchholders@1.0.1, realisticseawatersalt@1.0.0, fixscythe@0.2.1, shearsspeedscales@1.0.0, shelfobsessed@2.1.5, simpletankards@1.0.0, spinningwheel@1.2.9, stickisolation@1.0.0, stonequarryrepckfipil@3.6.3, thetruearchimedesscrew@0.2.0, game@1.22.3, worldgenfixremix@1.3.1, barkcanoe@1223.0.1, betterentityinteraction@1.0.5, bettererprospecting@3.3.3, betternails@2.0.3, bloodtrail@1.2.3, butchering@1.13.4, carryonlib@1.0.0-pre.4, chop@1.1.2, fixperishrate@1.0.1, juicyores@1.0.2, knitting@2.0.3, morepiles@3.0.1, orekiwoofsbeehives@2.0.0, pewter@1.4.0, claywheel@2.0.1, purposefulstorage@2.0.1, realsmoke@1.3.0, rebuildablebloomery@1.0.6, rivers@5.0.1, smithingplus@1.9.0-rc.1, spyglass@0.6.1, stablesurface@0.0.3, statushudcont@4.3.1, stonebakeoven@1.3.4, toolsmith@1.2.17, treetapredux@1.2.7, creative@1.22.3, vsroofing@1.5.7, survival@1.22.3, wateringcanfill@1.0.2, carryon@2.0.0-pre.4, littleropetweaks@1.0.0
Involved Harmony IDs: com.chronolegionnaire.hydrateordiedrate
System.NullReferenceException: Object reference not set to an instance of an object.
at SmithingPlus.ToolRecovery.CollectibleBehaviorRepairableTool.GetHeldItemInfo(ItemSlot inSlot, StringBuilder dsc, IWorldAccessor world, Boolean withDebugInfo) in /_/SmithingPlus/ToolRecovery/CollectibleBehaviorRepairableTool.cs:line 33
at Vintagestory.API.Common.CollectibleObject.GetHeldItemInfo_Patch1(CollectibleObject this, ItemSlot inSlot, StringBuilder dsc, IWorldAccessor world, Boolean withDebugInfo)
at Vintagestory.API.Common.Item.GetHeldItemInfo(ItemSlot inSlot, StringBuilder dsc, IWorldAccessor world, Boolean withDebugInfo) in VintagestoryApi\Common\Collectible\Item\Item.cs:line 82
at Vintagestory.API.Common.ItemStack.GetDescription(IWorldAccessor world, ItemSlot inSlot, Boolean debug) in VintagestoryApi\Common\Collectible\ItemStack.cs:line 402
at Vintagestory.Common.CreativeTab.CreateSearchCache(IWorldAccessor world) in VintagestoryLib\Common\GameContent\Inventory\CreativeTab.cs:line 47
at Vintagestory.Common.CreativeTabs.CreateSearchCache(IWorldAccessor world) in VintagestoryLib\Common\GameContent\Inventory\CreativeTabs.cs:line 50
at Vintagestory.Client.NoObf.GuiDialogInventory.b__6_0() in VintagestoryLib\Client\Systems\Gui\Dialogs\GuiDialogInventory.cs:line 60
at Vintagestory.API.Common.TyronThreadPool.<>c__DisplayClass11_0.b__0(Object _) in VintagestoryApi\Common\TyronThreadPool.cs:line 119
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
at System.Threading.Thread.StartCallback()

[Gmrkc]

I couldn't determine the specific circumstances causing the error, but sometimes it happens when exiting the game, preventing the game from saving and causing the loss of progress.

[Gmrkc]

Based on the comments from the creator of the "hydrate and dierate" mod, I modified "GetHeldItemInfo" method below. It's not giving me any errors locally now, and I'm continuing with the tests. Maybe it is helpfull.

public override void GetHeldItemInfo(ItemSlot? inSlot, StringBuilder dsc, IWorldAccessor world,
    bool withDebugInfo)
{
    if (inSlot != null)
    {
        base.GetHeldItemInfo(inSlot, dsc, world, withDebugInfo);
    }

    if (Core.Config == null || inSlot == null || inSlot.Itemstack == null)
    {
        return;
    }

    var itemstack = inSlot.Itemstack;
    var collectible = itemstack.Collectible;
    var code = collectible?.Code;

    if (code == null)
    {
        return;
    }

    if (!WildcardUtil.Match(Core.Config.RepairableToolSelector, code.ToString()))
        return;

    var brokenCount = itemstack.GetBrokenCount();
    if (brokenCount <= 0) return;

    if (Core.Config.ShowRepairedCount) dsc.AppendLine(Lang.Get($"{LangKey} {{0}} times", brokenCount));

    if (Core.Config.ShowRepairSmithName && itemstack.GetRepairSmith() is { } repairSmith)
        dsc.AppendLine(Lang.Get("Last repaired by {0}", repairSmith));
}