Bug: Cursor jumping around when codeblock re-renders

[scottrlarson]

Describe the bug
When adding enetries to the time-keep window, the cursor jumps to the bottom.

To Reproduce

1. Create a new timekeep view
2. Start adding sessions to the list until it fills the screen, or resize the screen to cover part of the list.

Expected behavior
When added a entry to the list, the page should not move.

Screenshots
https://web.tresorit.com/l/jUIFN#awaVEGuP_UPBUZzTsqcxQA

[jacobtread]

Unfortunately I'm pretty sure thats an unavoidable problem with how Obsidian renders code blocks 😓 I'm not doing anything to move the page around. I believe this is because when I save the data back to the file Obsidian goes and destroys then re-creates that code block which creates the jumping

[scottrlarson]

Unfortunately I'm pretty sure thats an unavoidable problem with how Obsidian renders code blocks 😓 I'm not doing anything to move the page around. I believe this is because when I save the data back to the file Obsidian goes and destroys then re-creates that code block which creates the jumping

I seem to remember you shared something about this before. I remembered it after the fact. Do you think I could submit a bug or feature request to obsidian to see if there can be a solution or work around for this ? The problem is it really makes adding new entries very tedious for long lists of items.

[scottrlarson]

Unfortunately I'm pretty sure thats an unavoidable problem with how Obsidian renders code blocks 😓 I'm not doing anything to move the page around. I believe this is because when I save the data back to the file Obsidian goes and destroys then re-creates that code block which creates the jumping

Another thing is, I haven't seen this behavior in other plug-ins that have long code blocks like dataview that render after update. Is it just because there is text input that causes this?

[jacobtread]

Unfortunately I'm pretty sure thats an unavoidable problem with how Obsidian renders code blocks 😓 I'm not doing anything to move the page around. I believe this is because when I save the data back to the file Obsidian goes and destroys then re-creates that code block which creates the jumping

Another thing is, I haven't seen this behavior in other plug-ins that have long code blocks like dataview that render after update. Is it just because there is text input that causes this?

I haven't looked into it too far but id assume in this case that its related to the buttons and/or the text boxes taking focus away from the file and Obsidian having to find a spot to restore focus to somewhere else

[scottrlarson]

Unfortunately I'm pretty sure thats an unavoidable problem with how Obsidian renders code blocks 😓 I'm not doing anything to move the page around. I believe this is because when I save the data back to the file Obsidian goes and destroys then re-creates that code block which creates the jumping

Another thing is, I haven't seen this behavior in other plug-ins that have long code blocks like dataview that render after update. Is it just because there is text input that causes this?

I haven't looked into it too far but id assume in this case that its related to the buttons and/or the text boxes taking focus away from the file and Obsidian having to find a spot to restore focus to somewhere else

I dont mind doing the work to see where this can be resolved, but where should start?

[jacobtread]

@scottrlarson I've been doing some looking into this today and I think what we have here is actually a different bug to what I've mentioned before.

I think it may be a bug with something in Obsidians "File properties" (Those things you've got at the top there). Can I get you to try and create a timekeep in a file without those and see if the bug still occurs there? I will be continuing to look into why this is happening on my end

Edit: Pre-empted that one there completely different behavior I've uncovered there haha! Not even the bug in question here just another instance of jumpy behavior

Edit Edit: Seems to be related to how much content is before & after to whether or not this jumpyness occurs and does seem to be related to the issue I previously mentioned I believe that was in a issue/PR about formatting the content to make it span multiple lines

[jacobtread]

I've got a sort of hacky solution which I've just implemented, its not really a be-all end-all solution but its a start at least. But it pretty much is:

• File write is about to happen (timekeep wants to save)
• Save the current scroll position
• Queue a task for 50ms later
• Restore the saved scroll position

It's a bit ugly as you see a little flicker of jumping down then back again as the codeblock renders but it does the job of keeping you where you were. Heres a before and after (Unfortunately the gif framerate is not quite high enough to pick up the slight jump haha):

[scottrlarson]

I've got a sort of hacky solution which I've just implemented, its not really a be-all end-all solution but its a start at least.

Yeah not sure how you got to work.. maybe my mind is tired right now. I look at it again tommrow. LOL. Thanks for looking at this, yeah I wanted to track my time for a month to see where I am at.

[jacobtread]

Have opened #60 with my little change and I'll try and get it out into a release soon while I try and figure out if I can hack on anything else on my end to make it work without doing an upstream bug report (As I'm not sure how feasible it is for them to actually "fix" it in Obsidian)

[scottrlarson]

Have opened #60 with my little change and I'll try and get it out into a release soon while I try and figure out if I can hack on anything else on my end to make it work without doing an upstream bug report (As I'm not sure how feasible it is for them to actually "fix" it in Obsidian)

Ok Thank you.. For awhile I have been using it for specific tasks, having a few entries per note, but creating a large note with a lot of entries, Im starting to think that maybe this isn't the best use of timekeep. Sorry to put extra load on you. I think its probably a good idea that I use a dedicated app for this so I am looking at alternatives. There is app for Linux called Time Keeper that seems to do what I need.

[4Source]

I have the feeling the flickering comes from react. I am not really a pro in react but it seems like that react creates for each rendering (createElement) a separate task. Rendering the TimesheetRow takes 0.54ms and the createTask takes 0.51ms.

I sadly can not proof without rebuilding the whole react code that the default way of obsidian would be faster. But maybe @jacobtread you are more experienced with react and you know a way of improving the existing react code.

If your interested in seeing if it would be better without react I maybe could allocate some time and rebuild it without react, if you not insist of using react.