🎯 Goal
Add unit tests for VetService to ensure business logic, validation rules, and error handling work correctly.
📦 Scope
🔹 createVet()
Test the following scenarios:
- ✅ Should create vet successfully when valid input
- ❌ Should throw ResourceNotFoundException when user does not exist
- ❌ Should throw BusinessRuleException when licenseId already exists
- ❌ Should throw BusinessRuleException when user is already registered as vet
- ✅ Should update user role to VET if not already set
- ❌ Should handle DataIntegrityViolationException and convert to BusinessRuleException
🔹 getAllVets()
- ✅ Should return list of all vets
- ✅ Should map Vet entities to VetResponse
🔹 getVetById(UUID id)
- ✅ Should return vet when found
- ❌ Should throw ResourceNotFoundException when vet does not exist
🧪 Technical Notes
- Use Mockito for mocking dependencies (VetRepository, UserRepository)
- Use @ExtendWith(MockitoExtension.class)
- Do NOT use Spring context (pure unit tests)
- Verify interactions with repositories where relevant
✅ Definition of Done
- All scenarios covered with unit tests
- Tests are isolated (no DB, no SpringBootTest)
- All tests pass locally and in CI
- Code follows project test conventions
🎯 Goal
Add unit tests for VetService to ensure business logic, validation rules, and error handling work correctly.
📦 Scope
🔹 createVet()
Test the following scenarios:
🔹 getAllVets()
🔹 getVetById(UUID id)
🧪 Technical Notes
✅ Definition of Done