Skip to content

Commit ade9820

Browse files
committed
address code review feedback from CodeRabbit
1 parent a09881e commit ade9820

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

src/main/java/org/juv25d/App.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ public static void main(String[] args) {
2020
HttpParser httpParser = new HttpParser();
2121

2222
Pipeline pipeline = new Pipeline();
23+
24+
pipeline.addGlobalFilter(new SecurityHeadersFilter(), 0);
25+
2326
// Configure redirect rules
2427
List<RedirectRule> redirectRules = List.of(
2528
new RedirectRule("/old-page", "/new-page", 301),
@@ -28,7 +31,6 @@ public static void main(String[] args) {
2831
);
2932
pipeline.addGlobalFilter(new RedirectFilter(redirectRules), 0);
3033

31-
3234
// IP filter is enabled but configured with open access during development
3335
// White/blacklist can be tightened when specific IP restrictions are decided
3436
pipeline.addGlobalFilter(new IpFilter(

src/main/java/org/juv25d/filter/SecurityHeadersFilter.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,16 @@ public class SecurityHeadersFilter implements Filter {
1313

1414
@Override
1515
public void doFilter(HttpRequest req, HttpResponse res, FilterChain chain) throws IOException {
16-
chain.doFilter(req, res);
16+
try {
17+
chain.doFilter(req, res);
18+
} finally {
1719

18-
res.setHeader("X-Content-Type-Options", "nosniff");
19-
res.setHeader("X-Frame-Options", "DENY");
20-
res.setHeader("X-XSS-Protection", "0");
21-
res.setHeader("Referrer-Policy", "no-referrer");
20+
res.setHeader("X-Content-Type-Options", "nosniff");
21+
res.setHeader("X-Frame-Options", "DENY");
22+
res.setHeader("X-XSS-Protection", "0");
23+
res.setHeader("Referrer-Policy", "no-referrer");
2224

25+
}
2326
}
2427
}
2528

0 commit comments

Comments
 (0)