ändrat latch await till 1sek för att hanterna timeout i test.

Author: Rickank

src/main/java/com/example/HelloModel.java

@@ -70,7 +70,7 @@ private void receiveMessage() {
             }
 
             if (System.getProperty("java.awt.headless", "false").equals("true")) {
-                messages.add(message); // lägg direkt i listan
+                messages.add(message);
                 return;
             }
 

src/test/java/com/example/HelloModelTest.java

@@ -29,7 +29,7 @@ static void setupJavaFX() {
         }
     }
 
-    //successful send tests
+    // successful send tests
     @Test
     void shouldSendMessageThroughConnection() throws InterruptedException {
         NtfyConnectionSpy connectionSpy = new NtfyConnectionSpy();
@@ -39,7 +39,7 @@ void shouldSendMessageThroughConnection() throws InterruptedException {
         CountDownLatch latch = new CountDownLatch(1);
         model.sendMessageAsync(success -> latch.countDown());
 
-        assertThat(latch.await(500, TimeUnit.MILLISECONDS)).isTrue();
+        assertThat(latch.await(1, TimeUnit.SECONDS)).isTrue();
         assertThat(connectionSpy.message).isEqualTo("Hello World");
     }
 
@@ -69,7 +69,7 @@ void shouldHandleMultipleConsecutiveSends() throws InterruptedException {
         assertThat(connectionSpy.message).isEqualTo("Second");
     }
 
-    //invalid send tests
+    // invalid send tests
     @Test
     void shouldRejectBlankMessages() throws InterruptedException {
         NtfyConnectionSpy connectionSpy = new NtfyConnectionSpy();
@@ -87,7 +87,7 @@ void shouldRejectBlankMessages() throws InterruptedException {
                 latch.countDown();
             });
 
-            latch.await(500, TimeUnit.MILLISECONDS);
+            latch.await(1, TimeUnit.SECONDS);
             assertThat(wasSuccessful[0]).isFalse();
             assertThat(connectionSpy.message).isNull();
         }
@@ -107,7 +107,7 @@ void shouldFailWhenSendingEmptyText() throws InterruptedException {
             latch.countDown();
         });
 
-        latch.await(500, TimeUnit.MILLISECONDS);
+        latch.await(1, TimeUnit.SECONDS);
         assertThat(wasSuccessful[0]).isFalse();
         assertThat(connectionSpy.message).isNull();
     }
@@ -126,12 +126,12 @@ void shouldFailWhenSendingNullMessage() throws InterruptedException {
             latch.countDown();
         });
 
-        latch.await(500, TimeUnit.MILLISECONDS);
+        latch.await(1, TimeUnit.SECONDS);
         assertThat(wasSuccessful[0]).isFalse();
         assertThat(connectionSpy.message).isNull();
     }
 
-    //error handling tests
+    // error handling tests
     @Test
     void shouldReturnFailureWhenConnectionFails() throws InterruptedException {
         NtfyConnection failingConn = new NtfyConnection() {
@@ -153,7 +153,7 @@ public void receive(Consumer<NtfyMessageDto> messageHandler) { }
             latch.countDown();
         });
 
-        latch.await(500, TimeUnit.MILLISECONDS);
+        latch.await(1, TimeUnit.SECONDS);
         assertThat(wasSuccessful[0]).isFalse();
         assertThat(model.getMessageToSend()).isEqualTo("Fail this message");
     }
@@ -184,11 +184,11 @@ public void receive(Consumer<NtfyMessageDto> messageHandler) { }
             latch.countDown();
         }
 
-        latch.await(500, TimeUnit.MILLISECONDS);
+        latch.await(1, TimeUnit.SECONDS);
         assertThat(wasSuccessful[0]).isFalse();
     }
 
-    //receiving messages tests
+    // receiving messages tests
     @Test
     void shouldAddIncomingMessageToList() throws InterruptedException {
         NtfyConnectionSpy connectionSpy = new NtfyConnectionSpy();
@@ -209,6 +209,7 @@ void shouldAddIncomingMessageToList() throws InterruptedException {
         assertThat(latch.await(1, TimeUnit.SECONDS)).isTrue();
         assertThat(model.getMessages()).contains(incomingMsg);
     }
+
     @Test
     void shouldDiscardNullIncomingMessage() throws InterruptedException {
         NtfyConnectionSpy connectionSpy = new NtfyConnectionSpy();
@@ -223,10 +224,11 @@ void shouldDiscardNullIncomingMessage() throws InterruptedException {
 
         connectionSpy.simulateIncoming(null);
 
-        boolean messageAdded = latch.await(500, TimeUnit.MILLISECONDS);
+        boolean messageAdded = latch.await(1, TimeUnit.SECONDS);
         assertThat(messageAdded).isFalse();
         assertThat(model.getMessages()).isEmpty();
     }
+
     @Test
     void shouldIgnoreMessagesWithBlankContent() throws InterruptedException {
         NtfyConnectionSpy connectionSpy = new NtfyConnectionSpy();
@@ -245,10 +247,11 @@ void shouldIgnoreMessagesWithBlankContent() throws InterruptedException {
         connectionSpy.simulateIncoming(whitespaceMsg);
         connectionSpy.simulateIncoming(emptyMsg);
 
-        boolean messageAdded = latch.await(500, TimeUnit.MILLISECONDS);
+        boolean messageAdded = latch.await(1, TimeUnit.SECONDS);
         assertThat(messageAdded).isFalse();
         assertThat(model.getMessages()).isEmpty();
     }
+
     @Test
     void shouldRejectAllInvalidIncomingMessages() throws InterruptedException {
         NtfyConnectionSpy connectionSpy = new NtfyConnectionSpy();
@@ -265,11 +268,12 @@ void shouldRejectAllInvalidIncomingMessages() throws InterruptedException {
         connectionSpy.simulateIncoming(new NtfyMessageDto("id2", 2, "message", "room", "  "));
         connectionSpy.simulateIncoming(null);
 
-        boolean messageAdded = latch.await(500, TimeUnit.MILLISECONDS);
+        boolean messageAdded = latch.await(1, TimeUnit.SECONDS);
         assertThat(messageAdded).isFalse();
         assertThat(model.getMessages()).isEmpty();
     }
-    //integration test
+
+    // integration test
     @Test
     void shouldCommunicateWithMockedServer(WireMockRuntimeInfo wmInfo) throws InterruptedException {
         NtfyConnectionImpl connection = new NtfyConnectionImpl("http://localhost:" + wmInfo.getHttpPort());