Skip to content

Commit 72eee3b

Browse files
committed
Changes after coderabbit review
1 parent 6b0e7fd commit 72eee3b

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

src/main/java/com/example/NtfyConnectionImpl.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ public class NtfyConnectionImpl implements NtfyConnection {
1717
private final String hostName;
1818
private final ObjectMapper mapper = new ObjectMapper();
1919

20-
2120
public NtfyConnectionImpl() {
2221
Dotenv dotenv = Dotenv.load();
2322
hostName = Objects.requireNonNull(dotenv.get("HOST_NAME"));
@@ -31,7 +30,7 @@ public NtfyConnectionImpl(String hostName) {
3130
public CompletableFuture<Void> send(String message) {
3231
HttpRequest httpRequest = HttpRequest.newBuilder()
3332
.POST(HttpRequest.BodyPublishers.ofString(message))
34-
.header("Cache", "no")
33+
.header("Cache-Control", "no")
3534
.uri(URI.create(hostName + "/mytopic"))
3635
.build();
3736

@@ -52,9 +51,15 @@ public void receive (Consumer < NtfyMessageDto > messageHandler) {
5251

5352
http.sendAsync(httpRequest, HttpResponse.BodyHandlers.ofLines())
5453
.thenAccept(response -> response.body()
55-
.map(s ->
56-
mapper.readValue(s, NtfyMessageDto.class))
57-
.filter(message -> message.event().equals("message"))
54+
.map(s -> {
55+
try {
56+
return mapper.readValue(s, NtfyMessageDto.class);
57+
} catch (Exception e) {
58+
System.out.println("Failed to parse message");
59+
return null;
60+
}
61+
})
62+
.filter(message -> message !=null && message.event().equals("message"))
5863
.peek(System.out::println)
5964
.forEach(messageHandler));
6065
}

src/main/resources/css/style.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ styles.css
2020
-fx-background-color: transparent;
2121
-fx-border-color: transparent;
2222
-fx-control-inner-background: transparent;
23+
-fx-font-size: 14;
2324
}
2425
/* Remove background and border on hover */
2526
.list-cell:filled:hover {
@@ -54,7 +55,6 @@ styles.css
5455
-fx-font-size: 16px;
5556
-fx-padding: 10px 20px;
5657
-fx-background-radius: 5px;
57-
-fx-transition: background-color 0.3s ease;
5858
}
5959
.button:hover{
6060
-fx-background-color: #0056b3;

0 commit comments

Comments
 (0)