Skip to content

Fix NCC bug with union members #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
foxtacles merged 1 commit into from
May 15, 2026
Merged

Fix NCC bug with union members #1755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/ncc/ncc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def get_scope_prefix(self, node, scope=None):
return self.scope_prefix_rule.global_prefix
elif (scope is CursorKind.CLASS_DECL) or (scope is CursorKind.CLASS_TEMPLATE):
return self.scope_prefix_rule.class_member_prefix
elif (scope is CursorKind.STRUCT_DECL):
elif (scope is CursorKind.STRUCT_DECL) or (scope is CursorKind.UNION_DECL):
return self.scope_prefix_rule.struct_member_prefix
return ""

Expand Down Expand Up @@ -617,7 +617,7 @@ def do_validate(options, filename):

if __name__ == "__main__":
logging.basicConfig(level=logging.DEBUG, format='%(asctime)s %(levelname)s %(message)s',
filename='log.txt', filemode='w')
filemode='w')

""" Parse all command line arguments and validate """
op = Options()
Expand Down
2 changes: 0 additions & 2 deletions tools/ncc/skip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ p_HELDesc: 'Allow this variable name'
e_RAMStream: 'Allow this enum constant'
p_RLE: 'Allow this parameter name'
p_milliseconds: 'Probably a bug with function call'
m_increaseAmount: "Can't currently detect member in union"
m_increaseFactor: "Can't currently detect member in union"
delta_rad: "Allow original naming from 1996"
delta_pos: "Allow original naming from 1996"
rot_mat: "Allow original naming from 1996"
Expand Down
Loading