-
Notifications
You must be signed in to change notification settings - Fork 30
fetch and http requests #154
Copy link
Copy link
Open
Labels
effort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a weekkind/maintenanceWork required to avoid breaking changes or harm to project's status quoWork required to avoid breaking changes or harm to project's status quostatus/blockedUnable to be worked further until needs are metUnable to be worked further until needs are met
Description
Metadata
Metadata
Assignees
Labels
effort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a weekkind/maintenanceWork required to avoid breaking changes or harm to project's status quoWork required to avoid breaking changes or harm to project's status quostatus/blockedUnable to be worked further until needs are metUnable to be worked further until needs are met
Type
Fields
Give feedbackNo fields configured for issues without a type.
This module exposes a HTTP class that lets you make HTTP requests. It accepts and returns interfaces from the browser fetch spec. Internally it juggles multiple fetch implementations between browsers, node, electron, and react native.
The types of all of these implementations differ to the degree that they are largely incompatible which means we
@ts-ignorea bunch of stuff which lets us move on but gives us no type safety and causes all sorts of weird bugs and code gymnastics in other parts of the codebase.We don't use or need the entirety of the fetch specification. Instead lets stop trying to be a general-purpose polymorphic fetch implementation and instead just expose the bits of the fetch API we use and have each implementation just service those bits.