From c2f731d030bb2edd3503827b85f002def06c8984 Mon Sep 17 00:00:00 2001 From: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> Date: Sun, 5 Feb 2023 13:52:12 -0700 Subject: [PATCH 1/3] fix: :rotating_light: fix line length --- js.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js.js b/js.js index 26d162d..a0324b9 100644 --- a/js.js +++ b/js.js @@ -34,6 +34,7 @@ module.exports = { 'no-warning-comments': 'warn', 'max-nested-callbacks': ['error', 4], 'max-depth': ['error', 4], + 'max-len': ['error', 120], 'require-yield': 'error', // plugins 'no-only-tests/no-only-tests': 'error', From 5f041ca9e858df0a7c3f0c01f224b0c98dda380e Mon Sep 17 00:00:00 2001 From: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> Date: Sun, 5 Feb 2023 13:52:47 -0700 Subject: [PATCH 2/3] fix: :rotating_light: Fix redundant return awaits except try-catch --- js.js | 1 + ts.js | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/js.js b/js.js index a0324b9..dec3d8b 100644 --- a/js.js +++ b/js.js @@ -30,6 +30,7 @@ module.exports = { 'no-implicit-coercion': 'error', 'no-loop-func': 'error', 'no-nested-ternary': 'warn', + 'no-return-await': 'off', 'no-script-url': 'error', 'no-warning-comments': 'warn', 'max-nested-callbacks': ['error', 4], diff --git a/ts.js b/ts.js index 9f1c118..ed21689 100644 --- a/ts.js +++ b/ts.js @@ -16,11 +16,12 @@ module.exports = { rules: { 'no-use-before-define': 'off', // Types often are recursive & no use before define is too restrictive 'etc/prefer-interface': 'error', // https://ncjamieson.com/prefer-interfaces/ - '@typescript-eslint/prefer-function-type': 'off', // conflicts with 'etc/prefer-interface' + '@typescript-eslint/await-thenable': 'error', // disallows awaiting a value that is not a "Thenable" '@typescript-eslint/explicit-function-return-type': 'error', // functions require return types '@typescript-eslint/no-this-alias': 'off', // allow 'const self = this' - '@typescript-eslint/await-thenable': 'error', // disallows awaiting a value that is not a "Thenable" + '@typescript-eslint/prefer-function-type': 'off', // conflicts with 'etc/prefer-interface' '@typescript-eslint/restrict-template-expressions': 'off', // allow values with `any` type in template literals + '@typescript-eslint/return-await': 'error', // disallows unnecessary return await 'jsdoc/require-param': 'off', // do not require jsdoc for params 'jsdoc/require-param-type': 'off' // allow compiler to derive param type } From dd5b3f3131c84ac19b769b5672046139c680f033 Mon Sep 17 00:00:00 2001 From: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> Date: Sun, 5 Feb 2023 13:59:04 -0700 Subject: [PATCH 3/3] fix: :rotating_light: yield-star-spacing --- js.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js.js b/js.js index dec3d8b..c2de750 100644 --- a/js.js +++ b/js.js @@ -37,6 +37,7 @@ module.exports = { 'max-depth': ['error', 4], 'max-len': ['error', 120], 'require-yield': 'error', + 'yield-star-spacing': ['error', 'after'], // plugins 'no-only-tests/no-only-tests': 'error', 'jsdoc/check-alignment': 'error',