Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Build failure with GCC 8.2.1 #26

@jamespharvey20

Description

@jamespharvey20

I'm making a quick assumption that this is due to errors that gcc 8.2.1 is giving that previous versions of gcc didn't. I could be wrong.

Turning -Werror off of course gets around this, but wanted to mention it.

psm_ep.c: In function ‘__psm_ep_open’:
psm_ep.c:1013:27: error: ‘%1d’ directive output may be truncated writing between 1 and 5 bytes into a region of size 4 [-Werror=format-truncation=]
      snprintf(pvalue, 4, "%1d", ports[0]);
                           ^~~
psm_ep.c:1013:26: note: directive argument in the range [0, 65535]
      snprintf(pvalue, 4, "%1d", ports[0]);
                          ^~~~~
psm_ep.c:1013:6: note: ‘snprintf’ output between 2 and 6 bytes into a destination of size 4
      snprintf(pvalue, 4, "%1d", ports[0]);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
psm_ep.c:1041:27: error: ‘%1d’ directive output may be truncated writing between 1 and 5 bytes into a region of size 4 [-Werror=format-truncation=]
      snprintf(pvalue, 4, "%1d", ports[i]);
                           ^~~
psm_ep.c:1041:26: note: directive argument in the range [0, 65535]
      snprintf(pvalue, 4, "%1d", ports[i]);
                          ^~~~~
psm_ep.c:1041:6: note: ‘snprintf’ output between 2 and 6 bytes into a destination of size 4
      snprintf(pvalue, 4, "%1d", ports[i]);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘psmi_parse_devices’,
    inlined from ‘__psm_ep_open’ at psm_ep.c:1003:16:
psm_ep.c:1352:5: error: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
     strncpy(e, devstring, len-1);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
psm_ep.c: In function ‘__psm_ep_open’:
psm_ep.c:1341:11: note: length computed here
     len = strlen(devstring)+1;
           ^~~~~~~~~~~~~~~~~

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions