feat(aws-sdk): added support for 3.1046.0#2556
Merged
Merged
Conversation
kirrg001
changed the title
|
abhilash-sivan
approved these changes
May 20, 2026
kirrg001
reviewed
May 20, 2026
| * The require hook can run once while `exports` is still `{}` (cyclic CJS load); `exports` is then the same object | ||
| * Node fills in later. Defer wrapping until after the current synchronous load completes. | ||
| */ | ||
| function instrumentGlobalSmithy(exports) { |
Contributor
There was a problem hiding this comment.
Theoretically we could add support for this problem into the requireHook.
But I have not seen this issue before. So lets see if we get more cases in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tada!