Possible enhancements for 2 fields:
=> The returned lab_sample_id seems to be the sample_id from the watina database and not from the lab. We could replace it by DimStaal.StaalExterneReferentie to get the real lab id.
The watina sample id is used for en_fecond_threshold though (in the joins), so we could define both:
mutate(lab_sample_id = sql("CAST(StaalExterneReferentie AS varchar)"),
sample_id = sql("CAST(StaalID AS varchar)"))
This would require a change in the code for en_fecond_threshold: the joins should be based on sample_id , not on lab_sample_id
=> The returned lab_project_id does not contain any information. We could export the labo report code from DimStaal.StaalExterneSource
In both cases: first check for a few examples, not only from the LIMS, but also analyses before the LIMS and analyses from other labs
Possible enhancements for 2 fields:
=> The returned
lab_sample_idseems to be thesample_idfrom the watina database and not from the lab. We could replace it byDimStaal.StaalExterneReferentieto get the real lab id.The watina sample id is used for
en_fecond_thresholdthough (in the joins), so we could define both:This would require a change in the code for
en_fecond_threshold: the joins should be based onsample_id, not onlab_sample_id=> The returned
lab_project_iddoes not contain any information. We could export the labo report code fromDimStaal.StaalExterneSourceIn both cases: first check for a few examples, not only from the LIMS, but also analyses before the LIMS and analyses from other labs