Skip to content

get_chem > lab_sample_id & lab_project_id #118

Description

@cecileherr

Possible enhancements for 2 fields:

=> The returned lab_sample_id seems to be the sample_id from the watina database and not from the lab. We could replace it by DimStaal.StaalExterneReferentie to get the real lab id.
The watina sample id is used for en_fecond_threshold though (in the joins), so we could define both:

mutate(lab_sample_id = sql("CAST(StaalExterneReferentie AS varchar)"),
          sample_id = sql("CAST(StaalID AS varchar)"))

This would require a change in the code for en_fecond_threshold: the joins should be based on sample_id , not on lab_sample_id

=> The returned lab_project_id does not contain any information. We could export the labo report code from DimStaal.StaalExterneSource

In both cases: first check for a few examples, not only from the LIMS, but also analyses before the LIMS and analyses from other labs

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions