Skip to content

Request for get_locs(): add 'filterlength_guessed' column in the return value #109

Description

@florisvdh

See:

watina/R/get.R

Lines 443 to 445 in fe50ec2

filterlength = ifelse(is.na(.data$FilterLengte),
0.3,
.data$FilterLengte),

and (PR #108):

watina/R/get.R

Lines 443 to 446 in a02cd40

filterlength = ifelse(is.na(.data$FilterLengte) |
.data$FilterLengte == 0,
0.3,
.data$FilterLengte),

Replacing missing (and in the future, also zero) filterlengths, by 0.3 m, has always been imposed by get_locs().

However this is not evident from the output, nor the documentation (not in documentation because the Value section needs to be extended; see also #47).

However in the output this should be made clear by including a filterlength_guessed variable (logical). This is similar to filterdepth_guessed; the latter appearing only if argument filterdepth_guess = TRUE.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions