Skip to content

[Example] Add ALS application#268

Open
Lucieno wants to merge 2 commits into
husky-team:masterfrom
Lucieno:master
Open

[Example] Add ALS application#268
Lucieno wants to merge 2 commits into
husky-team:masterfrom
Lucieno:master

Conversation

@Lucieno

@Lucieno Lucieno commented Mar 15, 2017

Copy link
Copy Markdown

Using push channel to implement an example of ALS.

Comment thread examples/CMakeLists.txt Outdated
target_link_libraries(ALS ${HUSKY_EXTERNAL_LIB})
husky_default_properties(ALS)

# Triangle counting

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant targets.

Comment thread examples/als.cpp Outdated
//
// Example of configuration
//
// master_host=master

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to put all information of configuration here. Be selective.

Comment thread examples/als.cpp Outdated
pred = std::max(1., pred);
pred = std::min(5., pred);
double loss = pred - rating;
// husky::LOG_I << "pred: " << pred;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all unused comments like this.

@kygx-legend kygx-legend changed the title [Example] modified ALS from old husky [Example] Add ALS application Mar 15, 2017
@ddmbr

ddmbr commented Mar 16, 2017

Copy link
Copy Markdown
Member

Actually it's better to use BroadcastChannel instead. However we need a proper BroadcastChannel first. See https://github.com/ddmbr/husky-h4/issues/116 and https://github.com/ddmbr/husky-h4/pull/115. A proper BroadcastChannel also exists in the old Husky repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants