[Combiner] Add a class for computing variance distributedly#235
Open
Kelvin-Ng wants to merge 1 commit into
Open
[Combiner] Add a class for computing variance distributedly#235Kelvin-Ng wants to merge 1 commit into
Kelvin-Ng wants to merge 1 commit into
Conversation
Member
|
I don't quite understand why put this class in combiner. Is it also a combiner or used by combiner?And could you add the unit test, which help users understand? |
Contributor
Author
|
Very rough pseudo code: |
Member
|
This is to calculate variance/standard deviation incrementally. Obviously it's not easy to give a good name... |
kygx-legend
requested changes
Feb 6, 2017
kygx-legend
left a comment
Member
There was a problem hiding this comment.
But I think it should have a unit test for this.
|
|
||
| class VarianceMeanNum { | ||
| public: | ||
| VarianceMeanNum() { |
Member
There was a problem hiding this comment.
VarianceMeanNum() : variance_(.0), mean_(.0), num_(0) {}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally in Random Forest in old Husky.
Now it is useful for @Gyingguo 's data visualization project.