DOC Fix incorrect LoRA references in hira and ln_tuning model docstrings#3291
Open
javierdejesusda wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3254. The
HiraModelandLNTuningModeldocstrings still describe their config as "the Lora model", copied fromlora/model.py. #3254 fixed this foradalora,boft,ia3, andxlorabut missed these two.hira/model.py: the docstring cross-referencedLoraConfig, butHiraModelis configured withHiraConfig. Updated both references toHiraConfigand the "Lora model" wording to "HiRA model".ln_tuning/model.py: theLNTuningConfigreferences were already correct, only the "Lora model" wording needed fixing.