FIX Remove duplicate VBLoRAConfig entry from peft.__all__#3279
Open
SHAI-Akshay-Tripathi wants to merge 2 commits into
Open
FIX Remove duplicate VBLoRAConfig entry from peft.__all__#3279SHAI-Akshay-Tripathi wants to merge 2 commits into
SHAI-Akshay-Tripathi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
peft.__all__listed"VBLoRAConfig"twice. Duplicate entries in__all__silently confuse documentation tooling, IDE auto-import, and linters that rely on__all__to determine the public API surface. It's the only duplicate among the 138 entries.Changes
src/peft/__init__.py— remove the duplicate line.tests/test_public_api.py— new test file with two regression tests:test_all_has_no_duplicates— guards against the same regression recurring.test_all_names_are_importable— verifies every name in__all__is actually accessible on the package.Verifying the regression test catches the bug
Per CONTRIBUTING.md, a bug fix should be accompanied by a test that fails on the broken code and passes on the fix:
__init__.pychange:test_all_has_no_duplicatesfails withAssertionError: Duplicate names in peft.__all__: {'VBLoRAConfig': 2}.How to test