Skip to content

Fix: target_modules as string incorrectly converted to set of characters #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chessing234 wants to merge 1 commit into from
Closed

Fix: target_modules as string incorrectly converted to set of characters #3275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/peft/utils/transformers_weight_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,16 @@ def _convert_peft_config_moe(peft_config, model_type: str) -> None:
if not fused_targets:
return

peft_config.target_parameters = set(peft_config.target_parameters or [])
peft_config.target_modules = set(peft_config.target_modules or [])
peft_config.target_parameters = (
{peft_config.target_parameters}
if isinstance(peft_config.target_parameters, str)
else set(peft_config.target_parameters or [])
)
peft_config.target_modules = (
{peft_config.target_modules}
if isinstance(peft_config.target_modules, str)
else set(peft_config.target_modules or [])
)
if not hasattr(peft_config, "rank_pattern") or peft_config.rank_pattern is None:
peft_config.rank_pattern = {}
if not hasattr(peft_config, "alpha_pattern") or peft_config.alpha_pattern is None:
Expand Down