Add UniLora tuner to PEFT#3257
Open
KaiyangLi1992 wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds UniLora, a LoRA-style parameter-efficient fine-tuning method that reconstructs LoRA parameters from a shared low-dimensional vector.
This is a fresh PR replacing #2968, because GitHub could not reopen the old closed PR after the head branch was updated.
What changed
PeftType.UNILORAand exposeUniLoraConfig/UniLoraModel.save_indicessupport for generated index and scale tensors.Notes for review
This branch is rebased on the latest
mainand incorporates the remaining review feedback from #2968, including naming, docs, tests, example, MetaMathQA config, deterministic index generation documentation,init_weights, and optional index saving.Tests
make stylemake qualityPYTHONPATH=src python -m pytest tests/test_unilora.pyPYTHONPATH=src python -m pytest --no-cov tests/test_custom_models.py -k UniLoraPYTHONPATH=src python -m pytest --no-cov tests/test_decoder_models.py -k UniLoraPYTHONPATH=src python -m pytest --no-cov tests/test_encoder_decoder_models.py -k UniLora