Theme Related Problems

[NABN00B]

Hi, I've started cooking themes yesterday and decided I should collect the problems I've encountered.

• 1. If an .ini file doesn't start with a definition [ but an empty line or a comment, an empty theme will be added to the selection menu. 591dfdd

  Details

  

• 2. When a tooltip is presented after enabling an option, the text color is hardcoded to be white(-ish) Even more checks and fixes #18800

  Details

  

• 3. PopupStyleBg has no adequate Foreground option, ItemStyleFg is used instead. Theme system fixes and additions #19984

  Details

  

• 4. InfoStyleBg seems to be unused (or at least I can't find it anywhere.) is only used in some tabs of System Information.

• 5. Headers usually don't have backgrounds but the Collapsible Headers under Control remapping do and use ItemStyleBg. This is inconsistent behavior. There is also no customizable header background color adequate to HeaderStyleFg.
  EDIT: collapsible headers use ItemStyleFg and ItemStyleBg since Improve some asserts, minor fixes (theme, warnings) #19547. Theme system fixes and additions #19984

  Details

  

• 6. Homebrew Store view has hardcoded colors in the title. Better control profile for Retroid devices, minor fixes and cleanup #19550 and Fix minor theme issue in Store #19582

  Details

  

• 7. We should consider resetting the Color Tint and Color Saturation options to their default values whenever a new Theme is selected. Better control profile for Retroid devices, minor fixes and cleanup #19550

• 8. The game list settings popup seems to be another can of worms... featuring the combination of PopupStyleBg, and HeaderStyleFg. Improve some asserts, minor fixes (theme, warnings) #19547 and More theming work #19995

  Details

  

• 9. The amount of background opacity, when the game is paused, is hardcoded.

• 10. When PopupStyleBg is transparent, there seems to be some radial gradient in play.

  Details

  

• 11. The Color Tint and Color Saturation popups remove the background when the game is paused, as if I were selecting shaders in the Display Layout screen.

• 12. Tooltips don't have separate colors and reuse PopupStyleBg/ItemStyleFg. This can lead to tooltips not being very distinguishable from menu items in some cases, such as with the Dark theme. The amount of transparency for hint popup backgrounds seems to be hardcoded. Theme system fixes and additions #19984

  Details

  

• 13. The default value of ThemeInfo::uPopupStyleBg was never updated from the old Holo inspired color to the current default PopupStyleBg. Improve custom themes #20333

• 14. The scrollbar is not customizable. Theme system fixes and additions #19984

• 15. The list of themes seems to get updated only when a new theme is selected, rather than when the list pops up. This is noticeable when extending an already existing .ini file with a new theme. (This doesn't happen with shader selection.)

• 16. (Not necessarily an issue, but worth noting.) Already existing themes can be overwritten by making the name field of a new theme match the original's. Because Default is both hardcoded and (redundantly) defined in defaultthemes.ini, this can lead to situations like 13.

  Details

  

• 17. When the last used theme no longer exists when the emulator is started, the first theme from the first file will be loaded, but the option will say Default. The proper default theme should be loaded instead. Theme system fixes and additions #19984

  Details

  

• 18. Rework color usage for sliders. See Theme Related Problems #18802 (comment) Make slider colors themable #20308

• 19. Clean up text input and label styles in popups. See Theme Related Problems #18802 (comment) More theming work #19995 and Exit fixes, AutoDNS fixes #19997

• 20. In the popup themes are listed in the order of the .ini's, rather than alphabetically. (This doesn't happen with shader selection.)

• 21. hrydgard proposes making the scrollbar fully opaque when being held down. See Theme Related Problems #18802 (comment)

New issues since the big UI overhaul:

• 22. The version label on the main screen below the PPSSPP typeface now uses ItemStyle (was previously InfoStyle)

  Details

  

• 23. The title of the currently selected tab in the Settings screen and Developer Tools is themed separately from other screen titles -- I think this type of element should receive its own style (fg + bg), maybe TitleStyle?

  Details

  

• 24. The descriptions for options use InfoStyle, which, except for System information, is never used with a background. The usage of InfoStyle here leads to unexpected color combinations. The background uses ItemStyleBg. More minor UI fixes, fix crash loading metadata from some PBPs #21268

  Details

  

Let's discuss all of this below.

[hrydgard]

1. Empty theme is a silly bug, I'll fix it right away.
2. Fixed in Even more checks and fixes #18800
3. Need to add, yes.
4. I'll clean that up.
5. I added backgrounds to collapsible headers to emphasize that they're clickable, but it indeed needs to be themable separately.

[hrydgard]

I think we need to think a bit more about the header background, it would be weird to now just add a HeaderStyleBg but only use it for collapsible headers.

I'll fix the popup color though shortly. Actually, that one's also a bit complicated.. since Choice might want different foreground depending on if it's in a popup or not.

I'm gonna have to postpone most of this to 1.18.

[NABN00B]

3. According to the files generated by https://ppsspp-theme-editor.onrender.com/ there used to be PopupStyleFg at one point.
   EDIT: This was removed by UI theme improvements #16779 for some reason.

[NABN00B]

• The game list settings popup seems to be another can of worms... featuring the combination of PopupStyleBg, and HeaderStyleFg. Improve some asserts, minor fixes (theme, warnings) #19547
  

[hrydgard]

Yeah.. It all needs a bit of an overhaul before it's really worth trying to theme it.

[hrydgard]

In #19547, I improve on this a bit (The headers in the gamelist properties get the default popup style), I changed the background of InfoStyle to look better.

[NABN00B]

In #19547, I improve on this a bit (The headers in the gamelist properties get the default popup style), I changed the background of InfoStyle to look better.

Thanks, and sorry for the distraction!
I understand that this was meant to fix the game list settings popup only, is that correct?

EDIT: looks like it also helped point 5.