From b43f8491bf63660decf7ed4f375e737fe0c0c7a8 Mon Sep 17 00:00:00 2001 From: Mohit Date: Sun, 14 Jun 2026 18:30:45 +0530 Subject: [PATCH] fix: improve windows include comments Signed-off-by: Mohit --- src/sdk/main/include/impl/BaseNode.h | 2 +- src/sdk/main/src/AccountId.cc | 2 +- src/sdk/main/src/FeeEstimateQuery.cc | 2 +- src/tck/src/TckServer.cc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sdk/main/include/impl/BaseNode.h b/src/sdk/main/include/impl/BaseNode.h index 0f38ac32b..db897d450 100644 --- a/src/sdk/main/include/impl/BaseNode.h +++ b/src/sdk/main/include/impl/BaseNode.h @@ -2,7 +2,7 @@ #ifndef HIERO_SDK_CPP_IMPL_BASE_NODE_H_ #define HIERO_SDK_CPP_IMPL_BASE_NODE_H_ -#include // This is needed for Windows to build for some reason. +#include // Must be included before any header that pulls in , whose macros (e.g. GetMessage) collide with identifiers in the generated protobuf code. #include "BaseNodeAddress.h" #include "Defaults.h" diff --git a/src/sdk/main/src/AccountId.cc b/src/sdk/main/src/AccountId.cc index 14f6665e9..c274620d2 100644 --- a/src/sdk/main/src/AccountId.cc +++ b/src/sdk/main/src/AccountId.cc @@ -1,5 +1,5 @@ // SPDX-License-Identifier: Apache-2.0 -// Windows build requires this to be included first for some reason. +// Must be included before any header that pulls in , whose macros (e.g. GetMessage) collide with identifiers in the generated protobuf code. #include // NOLINT #include "AccountId.h" diff --git a/src/sdk/main/src/FeeEstimateQuery.cc b/src/sdk/main/src/FeeEstimateQuery.cc index 656b10c8d..b0a071c97 100644 --- a/src/sdk/main/src/FeeEstimateQuery.cc +++ b/src/sdk/main/src/FeeEstimateQuery.cc @@ -1,5 +1,5 @@ // SPDX-License-Identifier: Apache-2.0 -// Windows build requires this to be included first for some reason. +// Must be included before any header that pulls in , whose macros (e.g. GetMessage) collide with identifiers in the generated protobuf code. #include // NOLINT #include "Client.h" diff --git a/src/tck/src/TckServer.cc b/src/tck/src/TckServer.cc index 7bf3fe5b5..b0dd85dd9 100644 --- a/src/tck/src/TckServer.cc +++ b/src/tck/src/TckServer.cc @@ -1,5 +1,5 @@ // SPDX-License-Identifier: Apache-2.0 -// Windows build requires this to be included first for some reason. +// Must be included before any header that pulls in , whose macros (e.g. GetMessage) collide with identifiers reached transitively from this header. #include // NOLINT #include "TckServer.h"