feat: add NK Landscape#29
Draft
WojtAcht wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an NK Landscape discrete benchmark problem to lonkit, making it available as a built-in BitstringProblem for ILS-based discrete LON construction, and documents/exports it across the public API.
Changes:
- Added
NKLandscapeimplementation (instance-seeded neighbor structure + contribution tables) with delta evaluation support. - Exported
NKLandscapefromlonkit.discrete.problems,lonkit.discrete, and top-levellonkit. - Added tests and documentation entries describing usage and parameters.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/discrete/test_problems.py | Adds unit tests covering determinism, neighbor models, delta evaluation, and local search properties for NKLandscape. |
| src/lonkit/discrete/problems/bitstring.py | Implements the NKLandscape problem. |
| src/lonkit/discrete/problems/init.py | Re-exports NKLandscape in the discrete problems package. |
| src/lonkit/discrete/init.py | Re-exports NKLandscape at the lonkit.discrete level. |
| src/lonkit/init.py | Re-exports NKLandscape at the top-level lonkit API. |
| README.md | Updates feature list to include NK Landscape as a built-in discrete problem. |
| docs/user-guide/discrete.md | Adds user guide section describing NKLandscape usage and parameters. |
| docs/index.md | Updates docs landing page feature summary to include NK Landscape. |
| docs/api/index.md | Adds NKLandscape to the API index list. |
| docs/api/discrete.md | Adds mkdocstrings entry for NKLandscape. |
| .gitignore | Ignores .gstack/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.