Bug: `getJSON` not defined — incompatibility with Hugo ≥ v0.156.0

[Ricardo-Simoes]

Following the official installation instructions at https://theme-cards.hbstack.dev/docs/install-from-scratch/, the last step (npm run dev) fails with the following error when using Hugo ≥ v0.156.0:

huge: downloading modules …
hugo: collected modules in 87854 ms
ERROR "/home/myuser/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/hugomods/giscus@v0.1.1/layouts/partials/giscus/repo-id.html:1:1": parse of template failed: template: _partials/giscus/repo-id.html:1: function "getJSON" not defined

Root cause

The getJSON template function was deprecated in Hugo v0.123.0 and permanently removed in Hugo v0.156.0 (see Hugo v0.156.0 release notes). The dependency github.com/hugomods/giscus@v0.1.1 still uses getJSON in layouts/partials/giscus/repo-id.html, which causes a hard parse error on Hugo ≥ v0.156.0.

Environment

• Hugo version: 0.157.0
• OS: Arch Linux
• Affected dependency: github.com/hugomods/giscus@v0.1.1
• Last known working Hugo version: 0.155.3

Steps to reproduce

1. Follow the instructions at https://theme-cards.hbstack.dev/docs/install-from-scratch/
2. Run npm run dev (which runs hugo server --gc -D)
3. Observe the error above

Expected behavior

hugo server starts without errors.

Suggested fix

The getJSON call in github.com/hugomods/giscus should be replaced with resources.GetRemote combined with transform.Unmarshal, as recommended by Hugo's migration guide. This may require updating the dependency on hugomods/giscus to a version that has already applied this fix, or patching it directly.

Reference: https://gohugo.io/functions/resources/getremote/

[lbrdt]

even with hugo 155.3, I'm getting errors in modules:

hugo: collected modules in 61507 msERROR error building site: render: [en v1.0.0 guest] failed to render pages: render of "/404" failed: "/opt/buildhome/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/hbstack/hb@v0.16.2/layouts/_default/baseof.html:20:8": execute of template failed: template: 404.html:20:8: executing "404.html" at <partial "hugopress/body-end" .>: error calling partial: "/opt/buildhome/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/hugomods/hugopress@v0.5.2/layouts/partials/hugopress/body-end.html:1:4": execute of template failed: template: _partials/hugopress/body-end.html:1:4: executing "_partials/hugopress/body-end.html" at <partial "hugopress/functions/render-hooks" (dict "Name" "body-end" "Page" .)>: error calling partial: "/opt/buildhome/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/hugomods/hugopress@v0.5.2/layouts/partials/hugopress/functions/render-hooks.html:27:10": execute of template failed: template: _partials/hugopress/functions/render-hooks.html:27:10: executing "_partials/hugopress/functions/render-hooks.html" at <partialCached .partial $ctx (index site.Params .cache_site_param_key)>: error calling partialCached: "/opt/buildhome/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/hbstack/search@v0.2.2/layouts/partials/hugopress/modules/hb-search/hooks/body-end.html:2:5": execute of template failed: template: _partials/hugopress/modules/hb-search/hooks/body-end.html:2:5: executing "_partials/hugopress/modules/hb-search/hooks/body-end.html" at <partial "search/assets/js" .Page>: error calling partial: "/opt/buildhome/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/hugomods/search@v0.20.0/layouts/partials/search/assets/js.html:5:19": execute of template failed: template: _partials/search/assets/js.html:5:19: executing "_partials/search/assets/js.html" at <$js.RelPermalink>: error calling RelPermalink: JSBUILD: failed to transform "/search/js/index.ts" (text/typescript): "/opt/buildhome/.cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/hugomods/search@v0.20.0/assets/search/js/engine.ts:2:17": Could not resolve "mods/fuse/fuse"

[Ricardo-Simoes]

even with hugo 155.3, I'm getting errors in modules:

Hummm, that's strange... I've downgraded my HUGO to 155.3 and got no errors...

[LITUATUI]

I now also get errors on 155.3