Add dependency on base64 (for ruby 3.4) - #353
Closed
nevans wants to merge 1 commit into
Closed
Conversation
Member
|
Included in #352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note: using conditionals inside the gemspec is problematic, as mentioned in other issues and PRs. For simplicity and consistency with the existing gemspec, I left it there anyway, since it'll be cleaned up by #352.
Note also that CI is not passing. #346 is required to fix CI. I split this PR off from that one in order to simplify release note generation.