Adding a block to do operations and close the connection in the end

[fabioperrella]

Hi!

First, great job with this gem, it helped us a lot!

After the merge of #175 , it is possible to use the shutdown method to close the connections, but what about having a method where it is possible to pass a block which will close the connection after yield it?

Example:

client.closing_connection do
  client.logical.read('something')
  client.login.write('something')
end

The implementation would be like this:

def closing_connection
  yield
ensure
  shutdown
end

The code is not 100% correct, it is just to show the ideia.

If you agree, I can send a pull request with this.

Thank you!

[chrisarcand]

Six years pass......

Thanks for the suggestion, but we're not going to add this feature. Here's why:

The vault-ruby client uses persistent HTTP connections with connection pooling specifically for performance. Shutting down the pool after every operation defeats the entire purpose of connection pooling. In normal usage, you want the connection pool to stay alive for the lifetime of your application.

If you really need to close connections after specific operations (like in one-off scripts), you can do it manually:

begin
  client.logical.read('something')
  client.logical.write('something_else')
ensure
  client.shutdown
end

For most applications, you shouldn't be calling shutdown at all - just let the connection pool persist and reuse connections across requests.