Notify newcomers to the gem that the current examples use older version of a specific secrets engine - #205
Closed
veeweeherman wants to merge 1 commit into
Closed
Notify newcomers to the gem that the current examples use older version of a specific secrets engine#205veeweeherman wants to merge 1 commit into
veeweeherman wants to merge 1 commit into
Conversation
…on of a specific secrets engine
|
|
Member
|
Fixed in #385 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds notes about current examples in README and which secrets engine it is meant for
Why
I'm a newcomer to Vault and when following the README I was slightly confused because the current examples (I believe) are for writing to a KV version 1 secrets engine. So I also included a link to Vault's secrets engines APIs so the next user can easily check how to write to the specific secrets engine they desire :)