Skip to content

Sharing iP code quality feedback [for @hansneddyanto] - Round 2 #4

Description

@nus-se-script

@hansneddyanto We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, so that you can avoid similar problems in your tP code (which will be graded more strictly for code quality).

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues 👍

Aspect: Naming boolean variables/methods

No easy-to-detect issues 👍

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

No easy-to-detect issues 👍

Aspect: Recent Git Commit Message

possible problems in commit 5721a70:


Improve code styling by reducing nested statements in method getResponse(String input)


  • Longer than 72 characters

possible problems in commit 7acef8e:


Add support for mass operations like mark, unmark, and delete tasks

The current system requires users to perform task operations one at a
time, making it inefficient to manage a large number of tasks.

Allowing users to perform operations on multiple tasks in one go
improves the efficiency of task management, especially when dealing
with large lists.

Implement mass operations by adding `MassMarkCommand`, `MassUnmarkCommand`,
and `MassDeleteCommand` to handle bulk task actions. These commands
search for tasks based on a keyword, display the matching tasks, and
prompt the user for confirmation before marking, unmarking, or deleting
tasks in bulk.

This approach ensures that users have control over bulk actions through
a confirmation process, reducing the chance of accidental changes.
It also maintains consistency with the existing command processing
flow, ensuring the user experience remains intuitive.

Multi-step user interactions are handled by storing the command state
until the user confirms the action, enabling a smooth multi-step
operation for bulk task management.


  • body not wrapped at 72 characters: e.g., Implement mass operations by adding MassMarkCommand, MassUnmarkCommand,

possible problems in commit 82370ce:


Merge branch 'master' of https://github.com/hansneddyanto/ip

* 'master' of https://github.com/hansneddyanto/ip:
  Codebase contains inconsistent indentation, redundant variables, and non-uniform variable names


  • body not wrapped at 72 characters: e.g., Codebase contains inconsistent indentation, redundant variables, and non-uniform variable names

Suggestion: Follow the given conventions for Git commit messages for future commits (do not modify past commit messages as doing so will change the commit timestamp that we used to detect your commit timings).

Aspect: Binary files in repo

No easy-to-detect issues 👍


❗ You are not required to (but you are welcome to) fix the above problems in your iP, unless you have been separately asked to resubmit the iP due to code quality issues.

ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@comp.nus.edu.sg if you want to follow up on this post.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions