Skip to content

Remove commons-collections from classpath #10335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niloc132 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −17
Open

Remove commons-collections from classpath #10335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
025a5ab
Remove commons-collections from classpath
niloc132 Jun 7, 2026
51d842f
Restore common-collections for test runtime classpath
niloc132 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions dev/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<pathelement location="${javac.out}"/>
<pathelement location="${alldeps.jar}"/>
<pathelement location="${gwt.tools.lib}/junit/junit-4.8.2.jar"/>
<pathelement location="${gwt.tools.lib}/apache/commons/commons-collections-3.2.2.jar"/>
</classpath>
</gwt.javac>
<gwt.javac srcdir="" destdir="${javac.junit.out}"
Expand Down Expand Up @@ -83,7 +84,6 @@
<include name="tomcat/tomcat-servlet-api-8.0.28.jar"/>
<include name="tomcat/tomcat-websocket-api-8.0.28.jar"/>
<include name="tomcat/tomcat-annotations-api-8.0.28.jar"/>
<include name="apache/commons/commons-collections-3.2.2.jar"/>

@zbynek zbynek Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes are still referenced in com.google.gwt.dev.util.collect.Hash(Map|Set)'s Javadoc, those references should be changed to http links or @code.

<!-- htmlunit dependencies not already included: BEGIN -->
<include name="apache/http/httpclient-4.5.13.jar"/>
<include name="apache/http/httpcore-4.4.13.jar"/>
Expand Down Expand Up @@ -152,8 +152,6 @@
<zipfileset src="${gwt.tools.lib}/tomcat/tomcat-servlet-api-8.0.28.jar"/>
<zipfileset src="${gwt.tools.lib}/tomcat/tomcat-websocket-api-8.0.28.jar"/>
<zipfileset src="${gwt.tools.lib}/tomcat/tomcat-annotations-api-8.0.28.jar"/>
<zipfileset
src="${gwt.tools.lib}/apache/commons/commons-collections-3.2.2.jar"/>
<!-- htmlunit dependencies not already included: BEGIN -->
<zipfileset src="${gwt.tools.lib}/apache/http/httpclient-4.5.13.jar"/>
<zipfileset src="${gwt.tools.lib}/apache/http/httpcore-4.4.13.jar"/>
Expand Down Expand Up @@ -220,8 +218,6 @@
<pathelement location="${gwt.tools.lib}/objectweb/asm-9.6/asm-9.6.jar"/>
<pathelement location="${gwt.tools.lib}/objectweb/asm-9.6/asm-commons-9.6.jar"/>
<pathelement location="${gwt.tools.lib}/objectweb/asm-9.6/asm-util-9.6.jar"/>
<pathelement
location="${gwt.tools.lib}/apache/commons/commons-collections-3.2.2.jar"/>
<fileset dir="${gwt.tools.lib}/eclipse/3.33.0">
<include name="**/*.jar"/>
</fileset>
Expand Down Expand Up @@ -326,10 +322,11 @@
<pathelement location="${gwt.root}/user/super/"/>
<!-- CompilerTest compiles the hello sample. -->
<pathelement location="${gwt.root}/samples/hello/src/main/java"/>
<!-- CompilerTest needs the dependecies to compile a project that uses UiBinder. -->
<pathelement location="${gwt.tools.lib}/streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-1.5-rebased.jar"/>
<!-- CompilerTest needs the dependencies to compile a project that uses UiBinder. -->
<pathelement location="${gwt.tools.lib}/streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-1.5-rebased.jar"/>
<pathelement location="${gwt.tools.lib}/gss/2015-11-04/closure-stylesheets-library-20151104-rebased.jar"/>
<pathelement location="${gwt.tools.lib}/jsinterop/jsinterop-annotations-2.0.0.jar"/>
<pathelement location="${gwt.tools.lib}/jsinterop/jsinterop-annotations-2.0.0.jar"/>
<pathelement location="${gwt.tools.lib}/apache/commons/commons-collections-3.2.2.jar"/>
</extraclasspaths>
</gwt.junit>
</target>
Expand Down
4 changes: 0 additions & 4 deletions maven/poms/gwt/gwt-dev/pom-template.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions maven/poms/gwt/pom-template.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,6 @@
<artifactId>colt</artifactId>
<version>1.2.0</version>
</dependency>
<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
<version>3.2.2</version>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
Expand Down
Loading