Skip to content

Add missing Override annotations #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zbynek wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add missing Override annotations #10324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83eb298
Add missing Override annotations
zbynek May 29, 2026
a861fb7
Configure ErrorProne warnings
zbynek May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 4 additions & 3 deletions .github/workflows/quick-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ jobs:
TZ=America/Los_Angeles \
ANT_OPTS=-Dfile.encoding=UTF8 \
ANT_OPTS=-Xmx2g
ant clean compile.tests dist doc checkstyle apicheck
ant clean compile.tests dist doc checkstyle apicheck | tee log.txt

- name: Create pull request comments/annotations for checkstyle from the java 21 build, even on failure
- name: Create pull request comments/annotations for Checkstyle and ErrorProne from the java 21 build, even on failure
if: ${{ always() && github.event_name == 'pull_request' && matrix.java-version == '21' }}
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -56,8 +56,9 @@ jobs:
cd gwt
for f in build/out/**/checkstyle*.xml ; do
echo $f
reviewdog -f=checkstyle -filter-mode=diff_context -reporter=github-pr-annotations -level=info < $f
reviewdog -f=checkstyle -filter-mode=diff_context -reporter=github-pr-annotations -level=info < $f || true
Comment thread
zbynek marked this conversation as resolved.
done
reviewdog -efm=" [javac] %f:%l: warning: %m" -filter-mode=diff_context -reporter=github-pr-annotations -level=info < log.txt || true
- name: Upload checkstyle xml for manual review
uses: actions/upload-artifact@v7
if: ${{ matrix.java-version == '21' }}
Expand Down
6 changes: 4 additions & 2 deletions common.ant.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<property name="javac.debuglevel" value="lines,vars,source"/>
<property name="javac.encoding" value="utf-8"/>
<property name="javac.release" value="11"/>
<property name="javac.nowarn" value="true"/>
<property name="javac.nowarn" value="false"/>

<!-- javac and errorprone instructions from https://errorprone.info/docs/installation#ant -->
<path id="errorprone.processorpath.ref">
Expand Down Expand Up @@ -161,7 +161,7 @@
<attribute name="release" default="${javac.release}" />
<attribute name="excludes" default="" />
<attribute name="processorpath" default="" />
<attribute name="errorprone.args" default="" />
<attribute name="errorprone.args" default="-XepDisableWarningsInGeneratedCode -xEp:MissingOverridde:ERROR -Xep:UnrecognisedJavadocTag:OFF -Xep:InvalidBlockTag:OFF -Xep:AnnotateFormatMethod:OFF -Xep:ProtectedMembersInFinalClass:OFF -Xep:TypeParameterUnusedInFormals:OFF -Xep:InvalidLink:OFF -Xep:NotJavadoc:OFF -Xep:OperatorPrecedence:OFF -Xep:IdentityHashMapUsage:OFF -Xep:DefaultCharset:OFF -Xep:StringSplitter:OFF -Xep:BadImport:OFF -Xep:UnusedVariable:OFF -Xep:JdkObsolete:OFF -Xep:SameNameButDifferent:OFF -Xep:InlineMeSuggester:OFF -Xep:UnnecessaryParentheses:OFF -Xep:NonApiType:OFF -Xep:InvalidInlineTag:OFF -Xep:ReferenceEquality:OFF -Xep:JavaUtilDate:OFF -xEp:MissingSummary:OFF -xEp:EmptyBlockTag:OFF" />
<element name="javaccontents" implicit="true" optional="true" />

<sequential>
Expand All @@ -184,6 +184,8 @@
<compilerarg value="-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED" />
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED" />
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED" />
<compilerarg value="-Xmaxwarns" />
<compilerarg value="99999" />
<compilerarg value="-XDcompilePolicy=simple"/>
<compilerarg value="-processorpath"/>
<compilerarg pathref="mergedprocessorpath.ref"/>
Expand Down
3 changes: 2 additions & 1 deletion dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ public CompilationUnitImpl(List<CompiledClass> compiledClasses,
}
this.hasErrors = hasAnyErrors;
this.hasJsInteropRootType = Iterables.any(types, new Predicate<JDeclaredType>() {
@Override public boolean apply(JDeclaredType type) {
@Override
public boolean apply(JDeclaredType type) {
return type.hasJsInteropEntryPoints();
}
});
Expand Down
Loading
Loading