Across DCAR, we override some team names provided by PA to match The Guardian's style guide:
|
export const cleanTeamName = (teamName: string): string => { |
This takes care of pages/components/atoms rendered in DCAR, but leaves anything rendered by frontend (e.g. Match Day atom, tables/leagues atoms and embeds etc) still carrying the original team names, which means not all cases are covered by the DCAR override and creates inconsistencies across the website and app where frontend atoms/components are used - see example below:
The purpose of this Issue is to explore how we best resolve this. Some potential (but maybe not all?) options to explore are:
- Changing the names further upstream so they permeate regardless of the platform used to render a component
- Adding a similar override that has been implemented in DCAR to frontend specifically
- Migrating the atoms/components rendered in frontend to DCAR, meaning no override is required in frontend as it no longer renders any affected atoms/components
There may also be other/better options for solving this.
The desired outcome is a recommendation for how we solve this as quickly as possible in the near-term as well as what a long-term solution might look like if that differs from the more immediate fix.
Across DCAR, we override some team names provided by PA to match The Guardian's style guide:
dotcom-rendering/dotcom-rendering/src/sportDataPage.ts
Line 95 in bdcd90d
This takes care of pages/components/atoms rendered in DCAR, but leaves anything rendered by frontend (e.g. Match Day atom, tables/leagues atoms and embeds etc) still carrying the original team names, which means not all cases are covered by the DCAR override and creates inconsistencies across the website and app where frontend atoms/components are used - see example below:
The purpose of this Issue is to explore how we best resolve this. Some potential (but maybe not all?) options to explore are:
There may also be other/better options for solving this.
The desired outcome is a recommendation for how we solve this as quickly as possible in the near-term as well as what a long-term solution might look like if that differs from the more immediate fix.