Skip to content

h2::Reason::FRAME_SIZE_ERROR should be mapped to Code::Internal #2577

@tobywf

Description

@tobywf

Bug Report

Version

master/079a223, originally found in v0.14.2

Platform

All platforms

Crates

tonic

Description

When constructing a Status from a h2::Error (like the RecoverError middleware does), it goes though Status::code_from_h2. FRAME_SIZE_ERROR (6) is missing, and so defaults to Code::Unknown. The spec says "INTERNAL". Happy to cut a PR, but wanted to check first whether it's deliberate or an oversight.

https://github.com/hyperium/tonic/blob/079a223a3a58d9f31411a5295f33211dd056fa9b/tonic/src/status.rs#L393-L412

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions