missing_presence_validation crashes with NoMethodError: undefined method 'exclude?' for Symbol

[andy-rootly]

Note: This issue was written with AI assistance.

Description

missing_presence_validation crashes when a model uses an inclusion or exclusion validator where :in is a Symbol (i.e., a method name):

validates :status, inclusion: { in: :allowed_statuses }

The detector calls .exclude? on the Symbol value, which fails because Symbol does not respond to exclude?.

Error

NoMethodError: undefined method 'exclude?' for an instance of Symbol

                  (validator_items.is_a?(Proc) || validator_items.exclude?(nil))
                                                                 ^^^^^^^^^

Root cause

In lib/active_record_doctor/detectors/missing_presence_validation.rb, inclusion_or_exclusion_validator_items returns validator.options[:in], which can be a Symbol when the validator delegates to a method. The calling code on lines 96 and 103 assumes the result responds to .exclude? / .include?, which Symbols do not.

Environment

• active_record_doctor 2.0.1
• Rails 8.0

[andy-rootly]

🤖 For reference, Rails' inclusion validator does support in: :method_name (Symbol) via ActiveModel::Validations::ResolveValue#resolve_value, which calls record.send(value) to resolve the Symbol to an enumerable at validation time.

Gist demonstrating the behavior: https://gist.github.com/andy-rootly/ac496359a70e918a203c60a356a39a6b

[fatkodima]

Had you closed accidentally? If yes, PR welcome.

[andy-rootly]

#239